mmc: vub300: fix an error code

Dan Carpenter · storulf · commit b44f9da81783 · 2023-11-03T12:04:34.000+01:00
This error path should return -EINVAL instead of success. Fixes: 88095e7 ("mmc: Add new VUB300 USB-to-SD/SDIO/MMC driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/0769d30c-ad80-421b-bf5d-7d6f5d85604e@moroto.mountain Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
@@ -2309,6 +2309,7 @@ static int vub300_probe(struct usb_interface *interface,
 		vub300->read_only =
 			(0x0010 & vub300->system_port_status.port_flags) ? 1 : 0;
 	} else {
+		retval = -EINVAL;
 		goto error5;
 	}
 	usb_set_intfdata(interface, vub300);

Original file line number	Diff line number	Diff line change
`@@ -2309,6 +2309,7 @@ static int vub300_probe(struct usb_interface *interface,`
`2309`	`2309`	`vub300->read_only =`
`2310`	`2310`	`(0x0010 & vub300->system_port_status.port_flags) ? 1 : 0;`
`2311`	`2311`	`} else {`
	`2312`	`+ retval = -EINVAL;`
`2312`	`2313`	`goto error5;`
`2313`	`2314`	`}`
`2314`	`2315`	`usb_set_intfdata(interface, vub300);`