Skip to content

Commit b488ae5

Browse files
michichanguy11
authored andcommitted
ice: sleep, don't busy-wait, in the SQ send retry loop
10 ms is a lot of time to spend busy-waiting. Sleeping is clearly allowed here, because we have just returned from ice_sq_send_cmd(), which takes a mutex. On kernels with HZ=100, this msleep may be twice as long, but I don't think it matters. I did not actually observe any retries happening here. Signed-off-by: Michal Schmidt <mschmidt@redhat.com> Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com> Reviewed-by: Simon Horman <simon.horman@corigine.com> Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
1 parent 43a630e commit b488ae5

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/net/ethernet/intel/ice/ice_common.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1643,7 +1643,7 @@ ice_sq_send_cmd_retry(struct ice_hw *hw, struct ice_ctl_q_info *cq,
16431643

16441644
memcpy(desc, &desc_cpy, sizeof(desc_cpy));
16451645

1646-
mdelay(ICE_SQ_SEND_DELAY_TIME_MS);
1646+
msleep(ICE_SQ_SEND_DELAY_TIME_MS);
16471647

16481648
} while (++idx < ICE_SQ_SEND_MAX_EXECUTE);
16491649

0 commit comments

Comments
 (0)