Skip to content

Commit b48aa99

Browse files
Aleksandr Mishinjic23
authored andcommitted
staging: iio: frequency: ad9834: Validate frequency parameter value
In ad9834_write_frequency() clk_get_rate() can return 0. In such case ad9834_calc_freqreg() call will lead to division by zero. Checking 'if (fout > (clk_freq / 2))' doesn't protect in case of 'fout' is 0. ad9834_write_frequency() is called from ad9834_write(), where fout is taken from text buffer, which can contain any value. Modify parameters checking. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 12b9d5b ("Staging: IIO: DDS: AD9833 / AD9834 driver") Suggested-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://patch.msgid.link/20240703154506.25584-1-amishin@t-argos.ru Cc: <Stable@vger.kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
1 parent 8400291 commit b48aa99

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/staging/iio/frequency/ad9834.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ static int ad9834_write_frequency(struct ad9834_state *st,
114114

115115
clk_freq = clk_get_rate(st->mclk);
116116

117-
if (fout > (clk_freq / 2))
117+
if (!clk_freq || fout > (clk_freq / 2))
118118
return -EINVAL;
119119

120120
regval = ad9834_calc_freqreg(clk_freq, fout);

0 commit comments

Comments
 (0)