Skip to content

Commit b4bd4f2

Browse files
committed
drm/i915/wm: convert intel_wm.c internally to struct intel_display
Going forward, struct intel_display is the main display device data pointer. Convert as much as possible of intel_wm.c to struct intel_display. Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com> Link: https://lore.kernel.org/r/6106c0313190ee904c7f7737d0b78b61983eed91.1744119460.git.jani.nikula@intel.com Signed-off-by: Jani Nikula <jani.nikula@intel.com>
1 parent 788f205 commit b4bd4f2

1 file changed

Lines changed: 61 additions & 61 deletions

File tree

drivers/gpu/drm/i915/display/intel_wm.c

Lines changed: 61 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@ int intel_wm_compute(struct intel_atomic_state *state,
6464
bool intel_initial_watermarks(struct intel_atomic_state *state,
6565
struct intel_crtc *crtc)
6666
{
67-
struct drm_i915_private *i915 = to_i915(state->base.dev);
67+
struct intel_display *display = to_intel_display(state);
6868

69-
if (i915->display.funcs.wm->initial_watermarks) {
70-
i915->display.funcs.wm->initial_watermarks(state, crtc);
69+
if (display->funcs.wm->initial_watermarks) {
70+
display->funcs.wm->initial_watermarks(state, crtc);
7171
return true;
7272
}
7373

@@ -77,27 +77,27 @@ bool intel_initial_watermarks(struct intel_atomic_state *state,
7777
void intel_atomic_update_watermarks(struct intel_atomic_state *state,
7878
struct intel_crtc *crtc)
7979
{
80-
struct drm_i915_private *i915 = to_i915(state->base.dev);
80+
struct intel_display *display = to_intel_display(state);
8181

82-
if (i915->display.funcs.wm->atomic_update_watermarks)
83-
i915->display.funcs.wm->atomic_update_watermarks(state, crtc);
82+
if (display->funcs.wm->atomic_update_watermarks)
83+
display->funcs.wm->atomic_update_watermarks(state, crtc);
8484
}
8585

8686
void intel_optimize_watermarks(struct intel_atomic_state *state,
8787
struct intel_crtc *crtc)
8888
{
89-
struct drm_i915_private *i915 = to_i915(state->base.dev);
89+
struct intel_display *display = to_intel_display(state);
9090

91-
if (i915->display.funcs.wm->optimize_watermarks)
92-
i915->display.funcs.wm->optimize_watermarks(state, crtc);
91+
if (display->funcs.wm->optimize_watermarks)
92+
display->funcs.wm->optimize_watermarks(state, crtc);
9393
}
9494

9595
int intel_compute_global_watermarks(struct intel_atomic_state *state)
9696
{
97-
struct drm_i915_private *i915 = to_i915(state->base.dev);
97+
struct intel_display *display = to_intel_display(state);
9898

99-
if (i915->display.funcs.wm->compute_global_watermarks)
100-
return i915->display.funcs.wm->compute_global_watermarks(state);
99+
if (display->funcs.wm->compute_global_watermarks)
100+
return display->funcs.wm->compute_global_watermarks(state);
101101

102102
return 0;
103103
}
@@ -179,22 +179,22 @@ void intel_wm_init(struct intel_display *display)
179179

180180
static void wm_latency_show(struct seq_file *m, const u16 wm[8])
181181
{
182-
struct drm_i915_private *dev_priv = m->private;
182+
struct intel_display *display = m->private;
183183
int level;
184184

185-
drm_modeset_lock_all(&dev_priv->drm);
185+
drm_modeset_lock_all(display->drm);
186186

187-
for (level = 0; level < dev_priv->display.wm.num_levels; level++) {
187+
for (level = 0; level < display->wm.num_levels; level++) {
188188
unsigned int latency = wm[level];
189189

190190
/*
191191
* - WM1+ latency values in 0.5us units
192192
* - latencies are in us on gen9/vlv/chv
193193
*/
194-
if (DISPLAY_VER(dev_priv) >= 9 ||
195-
IS_VALLEYVIEW(dev_priv) ||
196-
IS_CHERRYVIEW(dev_priv) ||
197-
IS_G4X(dev_priv))
194+
if (DISPLAY_VER(display) >= 9 ||
195+
display->platform.valleyview ||
196+
display->platform.cherryview ||
197+
display->platform.g4x)
198198
latency *= 10;
199199
else if (level > 0)
200200
latency *= 5;
@@ -203,18 +203,18 @@ static void wm_latency_show(struct seq_file *m, const u16 wm[8])
203203
level, wm[level], latency / 10, latency % 10);
204204
}
205205

206-
drm_modeset_unlock_all(&dev_priv->drm);
206+
drm_modeset_unlock_all(display->drm);
207207
}
208208

209209
static int pri_wm_latency_show(struct seq_file *m, void *data)
210210
{
211-
struct drm_i915_private *dev_priv = m->private;
211+
struct intel_display *display = m->private;
212212
const u16 *latencies;
213213

214-
if (DISPLAY_VER(dev_priv) >= 9)
215-
latencies = dev_priv->display.wm.skl_latency;
214+
if (DISPLAY_VER(display) >= 9)
215+
latencies = display->wm.skl_latency;
216216
else
217-
latencies = dev_priv->display.wm.pri_latency;
217+
latencies = display->wm.pri_latency;
218218

219219
wm_latency_show(m, latencies);
220220

@@ -223,13 +223,13 @@ static int pri_wm_latency_show(struct seq_file *m, void *data)
223223

224224
static int spr_wm_latency_show(struct seq_file *m, void *data)
225225
{
226-
struct drm_i915_private *dev_priv = m->private;
226+
struct intel_display *display = m->private;
227227
const u16 *latencies;
228228

229-
if (DISPLAY_VER(dev_priv) >= 9)
230-
latencies = dev_priv->display.wm.skl_latency;
229+
if (DISPLAY_VER(display) >= 9)
230+
latencies = display->wm.skl_latency;
231231
else
232-
latencies = dev_priv->display.wm.spr_latency;
232+
latencies = display->wm.spr_latency;
233233

234234
wm_latency_show(m, latencies);
235235

@@ -238,13 +238,13 @@ static int spr_wm_latency_show(struct seq_file *m, void *data)
238238

239239
static int cur_wm_latency_show(struct seq_file *m, void *data)
240240
{
241-
struct drm_i915_private *dev_priv = m->private;
241+
struct intel_display *display = m->private;
242242
const u16 *latencies;
243243

244-
if (DISPLAY_VER(dev_priv) >= 9)
245-
latencies = dev_priv->display.wm.skl_latency;
244+
if (DISPLAY_VER(display) >= 9)
245+
latencies = display->wm.skl_latency;
246246
else
247-
latencies = dev_priv->display.wm.cur_latency;
247+
latencies = display->wm.cur_latency;
248248

249249
wm_latency_show(m, latencies);
250250

@@ -253,39 +253,39 @@ static int cur_wm_latency_show(struct seq_file *m, void *data)
253253

254254
static int pri_wm_latency_open(struct inode *inode, struct file *file)
255255
{
256-
struct drm_i915_private *dev_priv = inode->i_private;
256+
struct intel_display *display = inode->i_private;
257257

258-
if (DISPLAY_VER(dev_priv) < 5 && !IS_G4X(dev_priv))
258+
if (DISPLAY_VER(display) < 5 && !display->platform.g4x)
259259
return -ENODEV;
260260

261-
return single_open(file, pri_wm_latency_show, dev_priv);
261+
return single_open(file, pri_wm_latency_show, display);
262262
}
263263

264264
static int spr_wm_latency_open(struct inode *inode, struct file *file)
265265
{
266-
struct drm_i915_private *dev_priv = inode->i_private;
266+
struct intel_display *display = inode->i_private;
267267

268-
if (HAS_GMCH(dev_priv))
268+
if (HAS_GMCH(display))
269269
return -ENODEV;
270270

271-
return single_open(file, spr_wm_latency_show, dev_priv);
271+
return single_open(file, spr_wm_latency_show, display);
272272
}
273273

274274
static int cur_wm_latency_open(struct inode *inode, struct file *file)
275275
{
276-
struct drm_i915_private *dev_priv = inode->i_private;
276+
struct intel_display *display = inode->i_private;
277277

278-
if (HAS_GMCH(dev_priv))
278+
if (HAS_GMCH(display))
279279
return -ENODEV;
280280

281-
return single_open(file, cur_wm_latency_show, dev_priv);
281+
return single_open(file, cur_wm_latency_show, display);
282282
}
283283

284284
static ssize_t wm_latency_write(struct file *file, const char __user *ubuf,
285285
size_t len, loff_t *offp, u16 wm[8])
286286
{
287287
struct seq_file *m = file->private_data;
288-
struct drm_i915_private *dev_priv = m->private;
288+
struct intel_display *display = m->private;
289289
u16 new[8] = {};
290290
int level;
291291
int ret;
@@ -302,15 +302,15 @@ static ssize_t wm_latency_write(struct file *file, const char __user *ubuf,
302302
ret = sscanf(tmp, "%hu %hu %hu %hu %hu %hu %hu %hu",
303303
&new[0], &new[1], &new[2], &new[3],
304304
&new[4], &new[5], &new[6], &new[7]);
305-
if (ret != dev_priv->display.wm.num_levels)
305+
if (ret != display->wm.num_levels)
306306
return -EINVAL;
307307

308-
drm_modeset_lock_all(&dev_priv->drm);
308+
drm_modeset_lock_all(display->drm);
309309

310-
for (level = 0; level < dev_priv->display.wm.num_levels; level++)
310+
for (level = 0; level < display->wm.num_levels; level++)
311311
wm[level] = new[level];
312312

313-
drm_modeset_unlock_all(&dev_priv->drm);
313+
drm_modeset_unlock_all(display->drm);
314314

315315
return len;
316316
}
@@ -319,13 +319,13 @@ static ssize_t pri_wm_latency_write(struct file *file, const char __user *ubuf,
319319
size_t len, loff_t *offp)
320320
{
321321
struct seq_file *m = file->private_data;
322-
struct drm_i915_private *dev_priv = m->private;
322+
struct intel_display *display = m->private;
323323
u16 *latencies;
324324

325-
if (DISPLAY_VER(dev_priv) >= 9)
326-
latencies = dev_priv->display.wm.skl_latency;
325+
if (DISPLAY_VER(display) >= 9)
326+
latencies = display->wm.skl_latency;
327327
else
328-
latencies = dev_priv->display.wm.pri_latency;
328+
latencies = display->wm.pri_latency;
329329

330330
return wm_latency_write(file, ubuf, len, offp, latencies);
331331
}
@@ -334,13 +334,13 @@ static ssize_t spr_wm_latency_write(struct file *file, const char __user *ubuf,
334334
size_t len, loff_t *offp)
335335
{
336336
struct seq_file *m = file->private_data;
337-
struct drm_i915_private *dev_priv = m->private;
337+
struct intel_display *display = m->private;
338338
u16 *latencies;
339339

340-
if (DISPLAY_VER(dev_priv) >= 9)
341-
latencies = dev_priv->display.wm.skl_latency;
340+
if (DISPLAY_VER(display) >= 9)
341+
latencies = display->wm.skl_latency;
342342
else
343-
latencies = dev_priv->display.wm.spr_latency;
343+
latencies = display->wm.spr_latency;
344344

345345
return wm_latency_write(file, ubuf, len, offp, latencies);
346346
}
@@ -349,13 +349,13 @@ static ssize_t cur_wm_latency_write(struct file *file, const char __user *ubuf,
349349
size_t len, loff_t *offp)
350350
{
351351
struct seq_file *m = file->private_data;
352-
struct drm_i915_private *dev_priv = m->private;
352+
struct intel_display *display = m->private;
353353
u16 *latencies;
354354

355-
if (DISPLAY_VER(dev_priv) >= 9)
356-
latencies = dev_priv->display.wm.skl_latency;
355+
if (DISPLAY_VER(display) >= 9)
356+
latencies = display->wm.skl_latency;
357357
else
358-
latencies = dev_priv->display.wm.cur_latency;
358+
latencies = display->wm.cur_latency;
359359

360360
return wm_latency_write(file, ubuf, len, offp, latencies);
361361
}
@@ -393,13 +393,13 @@ void intel_wm_debugfs_register(struct intel_display *display)
393393
struct drm_minor *minor = display->drm->primary;
394394

395395
debugfs_create_file("i915_pri_wm_latency", 0644, minor->debugfs_root,
396-
i915, &i915_pri_wm_latency_fops);
396+
display, &i915_pri_wm_latency_fops);
397397

398398
debugfs_create_file("i915_spr_wm_latency", 0644, minor->debugfs_root,
399-
i915, &i915_spr_wm_latency_fops);
399+
display, &i915_spr_wm_latency_fops);
400400

401401
debugfs_create_file("i915_cur_wm_latency", 0644, minor->debugfs_root,
402-
i915, &i915_cur_wm_latency_fops);
402+
display, &i915_cur_wm_latency_fops);
403403

404404
skl_watermark_debugfs_register(i915);
405405
}

0 commit comments

Comments
 (0)