Skip to content

Commit b4f5c6b

Browse files
committed
ASoC: wm8958: Fix change notifications for DSP controls
The WM8958 DSP controls all return 0 on successful write, not a boolean value indicating if the write changed the value of the control. Fix this by returning 1 after a change, there is already a check at the start of each put() that skips the function in the case that there is no change. Signed-off-by: Mark Brown <broonie@kernel.org> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com> Link: https://lore.kernel.org/r/20220416125408.197440-1-broonie@kernel.org Cc: stable@vger.kernel.org
1 parent 5b933c7 commit b4f5c6b

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

sound/soc/codecs/wm8958-dsp2.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -530,7 +530,7 @@ static int wm8958_mbc_put(struct snd_kcontrol *kcontrol,
530530

531531
wm8958_dsp_apply(component, mbc, wm8994->mbc_ena[mbc]);
532532

533-
return 0;
533+
return 1;
534534
}
535535

536536
#define WM8958_MBC_SWITCH(xname, xval) {\
@@ -656,7 +656,7 @@ static int wm8958_vss_put(struct snd_kcontrol *kcontrol,
656656

657657
wm8958_dsp_apply(component, vss, wm8994->vss_ena[vss]);
658658

659-
return 0;
659+
return 1;
660660
}
661661

662662

@@ -730,7 +730,7 @@ static int wm8958_hpf_put(struct snd_kcontrol *kcontrol,
730730

731731
wm8958_dsp_apply(component, hpf % 3, ucontrol->value.integer.value[0]);
732732

733-
return 0;
733+
return 1;
734734
}
735735

736736
#define WM8958_HPF_SWITCH(xname, xval) {\
@@ -824,7 +824,7 @@ static int wm8958_enh_eq_put(struct snd_kcontrol *kcontrol,
824824

825825
wm8958_dsp_apply(component, eq, ucontrol->value.integer.value[0]);
826826

827-
return 0;
827+
return 1;
828828
}
829829

830830
#define WM8958_ENH_EQ_SWITCH(xname, xval) {\

0 commit comments

Comments
 (0)