Skip to content

Commit b5a95bb

Browse files
committed
dt-bindings: media: Use graph and video-interfaces schemas, round 2
A couple of media schemas got applied without using or incorrectly using the video-interfaces.yaml and graph.yaml schemas. Fix them up before we have more copy-n-paste errors. Fixes: 41b3e23 ("media: dt-bindings: media: Add bindings for imx334") Fixes: d899e5f ("media: dt-bindings: media: imx258: add bindings for IMX258 sensor") Fixes: 918b866 ("media: dt-bindings: Remove old ov5647.yaml file, update ovti,ov5647.yaml") Fixes: 22f2b47 ("media: dt-bindings: media: i2c: Add OV8865 bindings documentation") Fixes: 29a202f ("media: dt-bindings: media: i2c: Add OV5648 bindings documentation") Cc: Sakari Ailus <sakari.ailus@linux.intel.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Dave Stevenson <dave.stevenson@raspberrypi.com> Cc: Jacopo Mondi <jacopo@jmondi.org> Cc: "Paul J. Murphy" <paul.j.murphy@intel.com> Cc: Daniele Alessandrelli <daniele.alessandrelli@intel.com> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Cc: linux-media@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Link: https://lore.kernel.org/r/20210223210127.55455-1-robh@kernel.org
1 parent 497a4dc commit b5a95bb

5 files changed

Lines changed: 24 additions & 38 deletions

File tree

Documentation/devicetree/bindings/media/i2c/imx258.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,14 @@ properties:
4949

5050
# See ../video-interfaces.txt for more details
5151
port:
52-
type: object
52+
$ref: /schemas/graph.yaml#/properties/port
53+
additionalProperties: false
54+
5355
properties:
5456
endpoint:
55-
type: object
57+
$ref: /schemas/media/video-interfaces.yaml#
58+
unevaluatedProperties: false
59+
5660
properties:
5761
data-lanes:
5862
oneOf:
@@ -65,11 +69,7 @@ properties:
6569
- const: 1
6670
- const: 2
6771

68-
link-frequencies:
69-
allOf:
70-
- $ref: /schemas/types.yaml#/definitions/uint64-array
71-
description:
72-
Allowed data bus frequencies.
72+
link-frequencies: true
7373

7474
required:
7575
- data-lanes

Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@ properties:
3131
maxItems: 1
3232

3333
port:
34-
$ref: /schemas/graph.yaml#/$defs/port-base
34+
$ref: /schemas/graph.yaml#/properties/port
35+
additionalProperties: false
3536

3637
properties:
3738
endpoint:
@@ -41,8 +42,6 @@ properties:
4142
properties:
4243
clock-noncontinuous: true
4344

44-
additionalProperties: false
45-
4645
required:
4746
- compatible
4847
- reg

Documentation/devicetree/bindings/media/i2c/ovti,ov5648.yaml

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -44,19 +44,17 @@ properties:
4444
description: Reset Pin GPIO Control (active low)
4545

4646
port:
47-
type: object
4847
description: MIPI CSI-2 transmitter port
48+
$ref: /schemas/graph.yaml#/properties/port
49+
additionalProperties: false
4950

5051
properties:
5152
endpoint:
52-
type: object
53+
$ref: /schemas/media/video-interfaces.yaml#
54+
unevaluatedProperties: false
5355

5456
properties:
55-
remote-endpoint: true
56-
57-
link-frequencies:
58-
$ref: /schemas/types.yaml#/definitions/uint64-array
59-
description: Allowed MIPI CSI-2 link frequencies
57+
link-frequencies: true
6058

6159
data-lanes:
6260
minItems: 1
@@ -65,10 +63,6 @@ properties:
6563
required:
6664
- data-lanes
6765
- link-frequencies
68-
- remote-endpoint
69-
70-
required:
71-
- endpoint
7266

7367
required:
7468
- compatible

Documentation/devicetree/bindings/media/i2c/ovti,ov8865.yaml

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -44,19 +44,17 @@ properties:
4444
description: Reset Pin GPIO Control (active low)
4545

4646
port:
47-
type: object
4847
description: MIPI CSI-2 transmitter port
48+
$ref: /schemas/graph.yaml#/properties/port
49+
additionalProperties: false
4950

5051
properties:
5152
endpoint:
52-
type: object
53+
$ref: /schemas/media/video-interfaces.yaml#
54+
unevaluatedProperties: false
5355

5456
properties:
55-
remote-endpoint: true
56-
57-
link-frequencies:
58-
$ref: /schemas/types.yaml#/definitions/uint64-array
59-
description: Allowed MIPI CSI-2 link frequencies
57+
link-frequencies: true
6058

6159
data-lanes:
6260
minItems: 1
@@ -65,10 +63,6 @@ properties:
6563
required:
6664
- data-lanes
6765
- link-frequencies
68-
- remote-endpoint
69-
70-
required:
71-
- endpoint
7266

7367
required:
7468
- compatible

Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,17 @@ properties:
3636
description: Reference to the GPIO connected to the XCLR pin, if any.
3737

3838
port:
39-
type: object
4039
additionalProperties: false
4140
$ref: /schemas/graph.yaml#/properties/port
4241

4342
properties:
4443
endpoint:
45-
type: object
44+
$ref: /schemas/media/video-interfaces.yaml#
45+
unevaluatedProperties: false
46+
4647
properties:
47-
data-lanes:
48-
$ref: ../video-interfaces.yaml#/properties/data-lanes
49-
link-frequencies:
50-
$ref: ../video-interfaces.yaml#/properties/link-frequencies
48+
data-lanes: true
49+
link-frequencies: true
5150

5251
required:
5352
- data-lanes

0 commit comments

Comments
 (0)