Skip to content

Commit b5c532e

Browse files
olsajirinamhyung
authored andcommitted
tools/build: Fix -s detection code in tools/scripts/Makefile.include
As Dmitry described in [1] changelog the current way of detecting -s option is broken for new make. Changing the tools/build -s option detection the same way as it was fixed for root Makefile in [1]. [1] 4bf7358 ("kbuild: Port silent mode detection to future gnu make.") Cc: Dmitry Goncharov <dgoncharov@users.sf.net> Signed-off-by: Jiri Olsa <jolsa@kernel.org> Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> Acked-by: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: KP Singh <kpsingh@chromium.org> Cc: Martin KaFai Lau <kafai@fb.com> Cc: Song Liu <songliubraving@fb.com> Cc: Yonghong Song <yhs@fb.com> Cc: John Fastabend <john.fastabend@gmail.com> Cc: Hao Luo <haoluo@google.com> Cc: Ian Rogers <irogers@google.com> Cc: Stanislav Fomichev <sdf@google.com> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Quentin Monnet <quentin@isovalent.com> Cc: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Andrii Nakryiko <andrii@kernel.org> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Ingo Molnar <mingo@kernel.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: bpf@vger.kernel.org Cc: linux-perf-users@vger.kernel.org Link: https://lore.kernel.org/r/20231008212251.236023-3-jolsa@kernel.org Signed-off-by: Namhyung Kim <namhyung@kernel.org>
1 parent d9997f7 commit b5c532e

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

tools/scripts/Makefile.include

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,15 @@ else
136136
NO_SUBDIR = :
137137
endif
138138

139-
ifneq ($(findstring s,$(filter-out --%,$(MAKEFLAGS))),)
139+
# If the user is running make -s (silent mode), suppress echoing of commands
140+
# make-4.0 (and later) keep single letter options in the 1st word of MAKEFLAGS.
141+
ifeq ($(filter 3.%,$(MAKE_VERSION)),)
142+
short-opts := $(firstword -$(MAKEFLAGS))
143+
else
144+
short-opts := $(filter-out --%,$(MAKEFLAGS))
145+
endif
146+
147+
ifneq ($(findstring s,$(short-opts)),)
140148
silent=1
141149
endif
142150

0 commit comments

Comments
 (0)