Skip to content

Commit b646488

Browse files
author
Daniel Thompson
committed
kdb: move kdb_send_sig() declaration to a better header file
kdb_send_sig() is defined in the signal code and called from kdb, but the declaration is part of the kdb internal code. Move the declaration to the shared header to avoid the warning: kernel/signal.c:4789:6: error: no previous prototype for 'kdb_send_sig' [-Werror=missing-prototypes] Reported-by: Arnd Bergmann <arnd@arndb.de> Closes: https://lore.kernel.org/lkml/20230517125423.930967-1-arnd@kernel.org/ Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org> Link: https://lore.kernel.org/r/20230630201206.2396930-1-daniel.thompson@linaro.org
1 parent 1ed0555 commit b646488

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

include/linux/kdb.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,8 @@ int kdb_process_cpu(const struct task_struct *p)
196196
return cpu;
197197
}
198198

199+
extern void kdb_send_sig(struct task_struct *p, int sig);
200+
199201
#ifdef CONFIG_KALLSYMS
200202
extern const char *kdb_walk_kallsyms(loff_t *pos);
201203
#else /* ! CONFIG_KALLSYMS */

kernel/debug/kdb/kdb_private.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ extern char kdb_task_state_char (const struct task_struct *);
194194
extern bool kdb_task_state(const struct task_struct *p, const char *mask);
195195
extern void kdb_ps_suppressed(void);
196196
extern void kdb_ps1(const struct task_struct *p);
197-
extern void kdb_send_sig(struct task_struct *p, int sig);
198197
extern char kdb_getchar(void);
199198
extern char *kdb_getstr(char *, size_t, const char *);
200199
extern void kdb_gdb_state_pass(char *buf);

0 commit comments

Comments
 (0)