Skip to content

Commit b68f91e

Browse files
Deepakkumar Karnbrauner
authored andcommitted
fs/buffer: add alert in try_to_free_buffers() for folios without buffers
try_to_free_buffers() can be called on folios with no buffers attached when filemap_release_folio() is invoked on a folio belonging to a mapping with AS_RELEASE_ALWAYS set but no release_folio operation defined. In such cases, folio_needs_release() returns true because of the AS_RELEASE_ALWAYS flag, but the folio has no private buffer data. This causes try_to_free_buffers() to call drop_buffers() on a folio with no buffers, leading to a null pointer dereference. Adding a check in try_to_free_buffers() to return early if the folio has no buffers attached, with WARN_ON_ONCE() to alert about the misconfiguration. This provides defensive hardening. Signed-off-by: Deepakkumar Karn <dkarn@redhat.com> Link: https://patch.msgid.link/20251211131211.308021-1-dkarn@redhat.com Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 961b2ad commit b68f91e

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

fs/buffer.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2948,6 +2948,10 @@ bool try_to_free_buffers(struct folio *folio)
29482948
if (folio_test_writeback(folio))
29492949
return false;
29502950

2951+
/* Misconfigured folio check */
2952+
if (WARN_ON_ONCE(!folio_buffers(folio)))
2953+
return true;
2954+
29512955
if (mapping == NULL) { /* can this still happen? */
29522956
ret = drop_buffers(folio, &buffers_to_free);
29532957
goto out;

0 commit comments

Comments
 (0)