Skip to content

Commit b72729b

Browse files
Uwe Kleine-Königdtor
authored andcommitted
Input: maceps2 - convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230920125829.1478827-38-u.kleine-koenig@pengutronix.de Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent 150e792 commit b72729b

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/input/serio/maceps2.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -148,20 +148,18 @@ static int maceps2_probe(struct platform_device *dev)
148148
return 0;
149149
}
150150

151-
static int maceps2_remove(struct platform_device *dev)
151+
static void maceps2_remove(struct platform_device *dev)
152152
{
153153
serio_unregister_port(maceps2_port[0]);
154154
serio_unregister_port(maceps2_port[1]);
155-
156-
return 0;
157155
}
158156

159157
static struct platform_driver maceps2_driver = {
160158
.driver = {
161159
.name = "maceps2",
162160
},
163161
.probe = maceps2_probe,
164-
.remove = maceps2_remove,
162+
.remove_new = maceps2_remove,
165163
};
166164

167165
static int __init maceps2_init(void)

0 commit comments

Comments
 (0)