Skip to content

Commit b79f2dc

Browse files
aharonl-nvidiajgunthorpe
authored andcommitted
RDMA/umem: Avoid undefined behavior of rounddown_pow_of_two()
rounddown_pow_of_two() is undefined when the input is 0. Therefore we need to avoid it in ib_umem_find_best_pgsz and return 0. Otherwise, it could result in not rejecting an invalid page size which eventually causes a kernel oops due to the logical inconsistency. Fixes: 3361c29 ("RDMA/umem: Use simpler logic for ib_umem_find_best_pgsz()") Link: https://lore.kernel.org/r/20210113121703.559778-2-leon@kernel.org Signed-off-by: Aharon Landau <aharonl@nvidia.com> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Reviewed-by: Maor Gottlieb <maorg@mellanox.com> Signed-off-by: Leon Romanovsky <leonro@nvidia.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
1 parent f2bc3af commit b79f2dc

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/infiniband/core/umem.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ unsigned long ib_umem_find_best_pgsz(struct ib_umem *umem,
135135
*/
136136
if (mask)
137137
pgsz_bitmap &= GENMASK(count_trailing_zeros(mask), 0);
138-
return rounddown_pow_of_two(pgsz_bitmap);
138+
return pgsz_bitmap ? rounddown_pow_of_two(pgsz_bitmap) : 0;
139139
}
140140
EXPORT_SYMBOL(ib_umem_find_best_pgsz);
141141

0 commit comments

Comments
 (0)