Skip to content

Commit b8ec1e7

Browse files
lumagrobclark
authored andcommitted
drm/msm/dp: move pdev from struct dp_display_private to struct msm_dp
The dp_drm needs accessing the DP's platform device. Move pdev to the public structure. Reviewed-by: Rob Clark <robdclark@gmail.com> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Patchwork: https://patchwork.freedesktop.org/patch/561642/ Signed-off-by: Rob Clark <robdclark@chromium.org>
1 parent 719093a commit b8ec1e7

2 files changed

Lines changed: 13 additions & 13 deletions

File tree

drivers/gpu/drm/msm/dp/dp_display.c

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ struct dp_display_private {
8888
bool audio_supported;
8989

9090
struct drm_device *drm_dev;
91-
struct platform_device *pdev;
9291
struct dentry *root;
9392

9493
struct dp_parser *parser;
@@ -595,7 +594,7 @@ static int dp_hpd_plug_handle(struct dp_display_private *dp, u32 data)
595594
return 0;
596595
}
597596

598-
ret = dp_display_usbpd_configure_cb(&dp->pdev->dev);
597+
ret = dp_display_usbpd_configure_cb(&dp->dp_display.pdev->dev);
599598
if (ret) { /* link train failed */
600599
dp->hpd_state = ST_DISCONNECTED;
601600
} else {
@@ -643,7 +642,7 @@ static int dp_hpd_unplug_handle(struct dp_display_private *dp, u32 data)
643642
if (dp->link->sink_count == 0) {
644643
dp_display_host_phy_exit(dp);
645644
}
646-
dp_display_notify_disconnect(&dp->pdev->dev);
645+
dp_display_notify_disconnect(&dp->dp_display.pdev->dev);
647646
mutex_unlock(&dp->event_mutex);
648647
return 0;
649648
} else if (state == ST_DISCONNECT_PENDING) {
@@ -653,7 +652,7 @@ static int dp_hpd_unplug_handle(struct dp_display_private *dp, u32 data)
653652
dp_ctrl_off_link(dp->ctrl);
654653
dp_display_host_phy_exit(dp);
655654
dp->hpd_state = ST_DISCONNECTED;
656-
dp_display_notify_disconnect(&dp->pdev->dev);
655+
dp_display_notify_disconnect(&dp->dp_display.pdev->dev);
657656
mutex_unlock(&dp->event_mutex);
658657
return 0;
659658
}
@@ -662,7 +661,7 @@ static int dp_hpd_unplug_handle(struct dp_display_private *dp, u32 data)
662661
* We don't need separate work for disconnect as
663662
* connect/attention interrupts are disabled
664663
*/
665-
dp_display_notify_disconnect(&dp->pdev->dev);
664+
dp_display_notify_disconnect(&dp->dp_display.pdev->dev);
666665

667666
if (state == ST_DISPLAY_OFF) {
668667
dp->hpd_state = ST_DISCONNECTED;
@@ -704,7 +703,7 @@ static int dp_irq_hpd_handle(struct dp_display_private *dp, u32 data)
704703
return 0;
705704
}
706705

707-
dp_display_usbpd_attention_cb(&dp->pdev->dev);
706+
dp_display_usbpd_attention_cb(&dp->dp_display.pdev->dev);
708707

709708
drm_dbg_dp(dp->drm_dev, "After, type=%d hpd_state=%d\n",
710709
dp->dp_display.connector_type, state);
@@ -725,12 +724,12 @@ static void dp_display_deinit_sub_modules(struct dp_display_private *dp)
725724
static int dp_init_sub_modules(struct dp_display_private *dp)
726725
{
727726
int rc = 0;
728-
struct device *dev = &dp->pdev->dev;
727+
struct device *dev = &dp->dp_display.pdev->dev;
729728
struct dp_panel_in panel_in = {
730729
.dev = dev,
731730
};
732731

733-
dp->parser = dp_parser_get(dp->pdev);
732+
dp->parser = dp_parser_get(dp->dp_display.pdev);
734733
if (IS_ERR(dp->parser)) {
735734
rc = PTR_ERR(dp->parser);
736735
DRM_ERROR("failed to initialize parser, rc = %d\n", rc);
@@ -791,7 +790,7 @@ static int dp_init_sub_modules(struct dp_display_private *dp)
791790
goto error_ctrl;
792791
}
793792

794-
dp->audio = dp_audio_get(dp->pdev, dp->panel, dp->catalog);
793+
dp->audio = dp_audio_get(dp->dp_display.pdev, dp->panel, dp->catalog);
795794
if (IS_ERR(dp->audio)) {
796795
rc = PTR_ERR(dp->audio);
797796
pr_err("failed to initialize audio, rc = %d\n", rc);
@@ -1197,7 +1196,7 @@ int dp_display_request_irq(struct msm_dp *dp_display)
11971196

11981197
dp = container_of(dp_display, struct dp_display_private, dp_display);
11991198

1200-
dp->irq = irq_of_parse_and_map(dp->pdev->dev.of_node, 0);
1199+
dp->irq = irq_of_parse_and_map(dp->dp_display.pdev->dev.of_node, 0);
12011200
if (!dp->irq) {
12021201
DRM_ERROR("failed to get irq\n");
12031202
return -EINVAL;
@@ -1253,7 +1252,7 @@ static int dp_display_probe(struct platform_device *pdev)
12531252
if (!desc)
12541253
return -EINVAL;
12551254

1256-
dp->pdev = pdev;
1255+
dp->dp_display.pdev = pdev;
12571256
dp->name = "drm_dp";
12581257
dp->id = desc->id;
12591258
dp->dp_display.connector_type = desc->connector_type;
@@ -1461,7 +1460,7 @@ void msm_dp_debugfs_init(struct msm_dp *dp_display, struct drm_minor *minor)
14611460
int rc;
14621461

14631462
dp = container_of(dp_display, struct dp_display_private, dp_display);
1464-
dev = &dp->pdev->dev;
1463+
dev = &dp->dp_display.pdev->dev;
14651464

14661465
dp->debug = dp_debug_get(dev, dp->panel,
14671466
dp->link, dp->dp_display.connector,
@@ -1481,7 +1480,7 @@ static int dp_display_get_next_bridge(struct msm_dp *dp)
14811480
struct device *dev;
14821481

14831482
dp_priv = container_of(dp, struct dp_display_private, dp_display);
1484-
dev = &dp_priv->pdev->dev;
1483+
dev = &dp_priv->dp_display.pdev->dev;
14851484
aux_bus = of_get_child_by_name(dev->of_node, "aux-bus");
14861485

14871486
if (aux_bus && dp->is_edp) {

drivers/gpu/drm/msm/dp/dp_display.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
struct msm_dp {
1414
struct drm_device *drm_dev;
15+
struct platform_device *pdev;
1516
struct device *codec_dev;
1617
struct drm_bridge *bridge;
1718
struct drm_connector *connector;

0 commit comments

Comments
 (0)