video: fbdev: omapfb: simplify the return expression of dsi_init_pll_data()

Minghao Chi · hdeller · commit b93a85c145d9 · 2022-05-19T11:16:49.000+02:00
Simplify the return expression.

Reported-by: Zeal Robot &lt;zealci@zte.com.cn&gt;
Signed-off-by: Minghao Chi &lt;chi.minghao@zte.com.cn&gt;
Signed-off-by: Helge Deller &lt;deller@gmx.de&gt;
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
@@ -173,7 +173,6 @@ static int dsi_init_pll_data(struct platform_device *pdev, struct hdmi_pll_data
 {
 	struct dss_pll *pll = &hpll->pll;
 	struct clk *clk;
-	int r;
 
 	clk = devm_clk_get(&pdev->dev, "sys_clk");
 	if (IS_ERR(clk)) {
@@ -203,12 +202,7 @@ static int dsi_init_pll_data(struct platform_device *pdev, struct hdmi_pll_data
 	}
 
 	pll->ops = &dsi_pll_ops;
-
-	r = dss_pll_register(pll);
-	if (r)
-		return r;
-
-	return 0;
+	return dss_pll_register(pll);
 }
 
 int hdmi_pll_init(struct platform_device *pdev, struct hdmi_pll_data *pll,

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,6 @@ static int dsi_init_pll_data(struct platform_device *pdev, struct hdmi_pll_data`
`173`	`173`	`{`
`174`	`174`	`struct dss_pll *pll = &hpll->pll;`
`175`	`175`	`struct clk *clk;`
`176`		`- int r;`
`177`	`176`
`178`	`177`	`clk = devm_clk_get(&pdev->dev, "sys_clk");`
`179`	`178`	`if (IS_ERR(clk)) {`
`@@ -203,12 +202,7 @@ static int dsi_init_pll_data(struct platform_device *pdev, struct hdmi_pll_data`
`203`	`202`	`}`
`204`	`203`
`205`	`204`	`pll->ops = &dsi_pll_ops;`
`206`		`-`
`207`		`- r = dss_pll_register(pll);`
`208`		`- if (r)`
`209`		`- return r;`
`210`		`-`
`211`		`- return 0;`
	`205`	`+ return dss_pll_register(pll);`
`212`	`206`	`}`
`213`	`207`
`214`	`208`	`int hdmi_pll_init(struct platform_device pdev, struct hdmi_pll_data pll,`