s390/processor: let cpu helper functions return boolean values

hcahca · hcahca · commit b977f03ec44a · 2023-02-15T11:07:01.000+01:00
Let cpu helper functions return boolean values. This also allows to
make the code a bit simpler by getting rid of the "!!" construct.

Reviewed-by: Sven Schnelle &lt;svens@linux.ibm.com&gt;
Signed-off-by: Heiko Carstens &lt;hca@linux.ibm.com&gt;
diff --git a/arch/s390/include/asm/processor.h b/arch/s390/include/asm/processor.h
@@ -54,19 +54,20 @@ static __always_inline void clear_cpu_flag(int flag)
 	S390_lowcore.cpu_flags &= ~(1UL << flag);
 }
 
-static __always_inline int test_cpu_flag(int flag)
+static __always_inline bool test_cpu_flag(int flag)
 {
-	return !!(S390_lowcore.cpu_flags & (1UL << flag));
+	return S390_lowcore.cpu_flags & (1UL << flag);
 }
 
 /*
  * Test CIF flag of another CPU. The caller needs to ensure that
  * CPU hotplug can not happen, e.g. by disabling preemption.
  */
-static __always_inline int test_cpu_flag_of(int flag, int cpu)
+static __always_inline bool test_cpu_flag_of(int flag, int cpu)
 {
 	struct lowcore *lc = lowcore_ptr[cpu];
-	return !!(lc->cpu_flags & (1UL << flag));
+
+	return lc->cpu_flags & (1UL << flag);
 }
 
 #define arch_needs_cpu() test_cpu_flag(CIF_NOHZ_DELAY)

Original file line number	Diff line number	Diff line change
`@@ -54,19 +54,20 @@ static __always_inline void clear_cpu_flag(int flag)`
`54`	`54`	`S390_lowcore.cpu_flags &= ~(1UL << flag);`
`55`	`55`	`}`
`56`	`56`
`57`		`-static __always_inline int test_cpu_flag(int flag)`
	`57`	`+static __always_inline bool test_cpu_flag(int flag)`
`58`	`58`	`{`
`59`		`- return !!(S390_lowcore.cpu_flags & (1UL << flag));`
	`59`	`+ return S390_lowcore.cpu_flags & (1UL << flag);`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`/*`
`63`	`63`	`* Test CIF flag of another CPU. The caller needs to ensure that`
`64`	`64`	`* CPU hotplug can not happen, e.g. by disabling preemption.`
`65`	`65`	`*/`
`66`		`-static __always_inline int test_cpu_flag_of(int flag, int cpu)`
	`66`	`+static __always_inline bool test_cpu_flag_of(int flag, int cpu)`
`67`	`67`	`{`
`68`	`68`	`struct lowcore *lc = lowcore_ptr[cpu];`
`69`		`- return !!(lc->cpu_flags & (1UL << flag));`
	`69`	`+`
	`70`	`+ return lc->cpu_flags & (1UL << flag);`
`70`	`71`	`}`
`71`	`72`
`72`	`73`	`#define arch_needs_cpu() test_cpu_flag(CIF_NOHZ_DELAY)`