nvmet-tcp: fix kmap leak when data digest in use

Elad Grupi · Christoph Hellwig · commit bac04454ef9f · 2021-03-18T05:39:18.000+01:00
When data digest is enabled we should unmap pdu iovec before handling
the data digest pdu.

Signed-off-by: Elad Grupi &lt;elad.grupi@dell.com&gt;
Reviewed-by: Sagi Grimberg &lt;sagi@grimberg.me&gt;
Signed-off-by: Christoph Hellwig &lt;hch@lst.de&gt;
diff --git a/drivers/nvme/target/tcp.c b/drivers/nvme/target/tcp.c
@@ -1098,11 +1098,11 @@ static int nvmet_tcp_try_recv_data(struct nvmet_tcp_queue *queue)
 		cmd->rbytes_done += ret;
 	}
 
+	nvmet_tcp_unmap_pdu_iovec(cmd);
 	if (queue->data_digest) {
 		nvmet_tcp_prep_recv_ddgst(cmd);
 		return 0;
 	}
-	nvmet_tcp_unmap_pdu_iovec(cmd);
 
 	if (!(cmd->flags & NVMET_TCP_F_INIT_FAILED) &&
 	    cmd->rbytes_done == cmd->req.transfer_len) {

Original file line number	Diff line number	Diff line change
`@@ -1098,11 +1098,11 @@ static int nvmet_tcp_try_recv_data(struct nvmet_tcp_queue *queue)`
`1098`	`1098`	`cmd->rbytes_done += ret;`
`1099`	`1099`	`}`
`1100`	`1100`
	`1101`	`+ nvmet_tcp_unmap_pdu_iovec(cmd);`
`1101`	`1102`	`if (queue->data_digest) {`
`1102`	`1103`	`nvmet_tcp_prep_recv_ddgst(cmd);`
`1103`	`1104`	`return 0;`
`1104`	`1105`	`}`
`1105`		`- nvmet_tcp_unmap_pdu_iovec(cmd);`
`1106`	`1106`
`1107`	`1107`	`if (!(cmd->flags & NVMET_TCP_F_INIT_FAILED) &&`
`1108`	`1108`	`cmd->rbytes_done == cmd->req.transfer_len) {`