ublk_drv: update comment for __ublk_fail_req()

old-memories · axboe · commit bb24174754af · 2022-08-16T06:16:19.000-06:00
Since __ublk_rq_task_work always fails requests immediately during exiting, __ublk_fail_req() is only called from abort context during exiting. So lock is unnecessary. Signed-off-by: ZiyangZhang <ZiyangZhang@linux.alibaba.com> Reviewed-by: Ming Lei <ming.lei@redhat.com> Link: https://lore.kernel.org/r/20220815023633.259825-3-ZiyangZhang@linux.alibaba.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
@@ -605,8 +605,9 @@ static void ublk_complete_rq(struct request *req)
 }
 
 /*
- * __ublk_fail_req() may be called from abort context or ->ubq_daemon
- * context during exiting, so lock is required.
+ * Since __ublk_rq_task_work always fails requests immediately during
+ * exiting, __ublk_fail_req() is only called from abort context during
+ * exiting. So lock is unnecessary.
  *
  * Also aborting may not be started yet, keep in mind that one failed
  * request may be issued by block layer again.

Original file line number	Diff line number	Diff line change
`@@ -605,8 +605,9 @@ static void ublk_complete_rq(struct request *req)`
`605`	`605`	`}`
`606`	`606`
`607`	`607`	`/*`
`608`		`- * __ublk_fail_req() may be called from abort context or ->ubq_daemon`
`609`		`- * context during exiting, so lock is required.`
	`608`	`+ * Since __ublk_rq_task_work always fails requests immediately during`
	`609`	`+ * exiting, __ublk_fail_req() is only called from abort context during`
	`610`	`+ * exiting. So lock is unnecessary.`
`610`	`611`	`*`
`611`	`612`	`* Also aborting may not be started yet, keep in mind that one failed`
`612`	`613`	`* request may be issued by block layer again.`