gfs2: remove dead code in add_to_queue

Su Hui · Andreas Gruenbacher · commit bb25b97562e5 · 2023-11-06T01:51:26.000+01:00
clang static analyzer complains that value stored to 'gh' is never read. The code of this line is useless after commit 0b93bac ("gfs2: Remove LM_FLAG_PRIORITY flag"). Remove this code to save space. Signed-off-by: Su Hui <suhui@nfschina.com> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
@@ -1524,7 +1524,6 @@ __acquires(&gl->gl_lockref.lock)
 		return;
 	}
 	list_add_tail(&gh->gh_list, insert_pt);
-	gh = list_first_entry(&gl->gl_holders, struct gfs2_holder, gh_list);
 	spin_unlock(&gl->gl_lockref.lock);
 	if (sdp->sd_lockstruct.ls_ops->lm_cancel)
 		sdp->sd_lockstruct.ls_ops->lm_cancel(gl);

Original file line number	Diff line number	Diff line change
`@@ -1524,7 +1524,6 @@ __acquires(&gl->gl_lockref.lock)`
`1524`	`1524`	`return;`
`1525`	`1525`	`}`
`1526`	`1526`	`list_add_tail(&gh->gh_list, insert_pt);`
`1527`		`- gh = list_first_entry(&gl->gl_holders, struct gfs2_holder, gh_list);`
`1528`	`1527`	`spin_unlock(&gl->gl_lockref.lock);`
`1529`	`1528`	`if (sdp->sd_lockstruct.ls_ops->lm_cancel)`
`1530`	`1529`	`sdp->sd_lockstruct.ls_ops->lm_cancel(gl);`