Skip to content

Commit bb27226

Browse files
Zqianghtejun
authored andcommitted
sched_ext: Remove unused code in the do_pick_task_scx()
The kick_idle variable is no longer used, this commit therefore remove it and also remove associated code in the do_pick_task_scx(). Signed-off-by: Zqiang <qiang.zhang@linux.dev> Reviewed-by: Andrea Righi <arighi@nvidia.com> Reviewed-by: Emil Tsalapatis <emil@etsalapatis.com> Signed-off-by: Tejun Heo <tj@kernel.org>
1 parent 579a329 commit bb27226

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

kernel/sched/ext.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2446,7 +2446,7 @@ static struct task_struct *
24462446
do_pick_task_scx(struct rq *rq, struct rq_flags *rf, bool force_scx)
24472447
{
24482448
struct task_struct *prev = rq->curr;
2449-
bool keep_prev, kick_idle = false;
2449+
bool keep_prev;
24502450
struct task_struct *p;
24512451

24522452
/* see kick_cpus_irq_workfn() */
@@ -2488,12 +2488,8 @@ do_pick_task_scx(struct rq *rq, struct rq_flags *rf, bool force_scx)
24882488
refill_task_slice_dfl(rcu_dereference_sched(scx_root), p);
24892489
} else {
24902490
p = first_local_task(rq);
2491-
if (!p) {
2492-
if (kick_idle)
2493-
scx_kick_cpu(rcu_dereference_sched(scx_root),
2494-
cpu_of(rq), SCX_KICK_IDLE);
2491+
if (!p)
24952492
return NULL;
2496-
}
24972493

24982494
if (unlikely(!p->scx.slice)) {
24992495
struct scx_sched *sch = rcu_dereference_sched(scx_root);

0 commit comments

Comments
 (0)