Skip to content

Commit bbf4790

Browse files
saschahauerchanwoochoi
authored andcommitted
PM / devfreq: rockchip-dfi: Embed desc into private data struct
No need for an extra allocation, just embed the struct devfreq_event_desc into the private data struct. Link: https://lore.kernel.org/lkml/20230704093242.583575-3-s.hauer@pengutronix.de/ Reviewed-by: Heiko Stuebner <heiko@sntech.de> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
1 parent 1e0731c commit bbf4790

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

drivers/devfreq/event/rockchip-dfi.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ struct dmc_usage {
4949
*/
5050
struct rockchip_dfi {
5151
struct devfreq_event_dev *edev;
52-
struct devfreq_event_desc *desc;
52+
struct devfreq_event_desc desc;
5353
struct dmc_usage ch_usage[RK3399_DMC_NUM_CH];
5454
struct device *dev;
5555
void __iomem *regs;
@@ -204,14 +204,10 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
204204

205205
data->dev = dev;
206206

207-
desc = devm_kzalloc(dev, sizeof(*desc), GFP_KERNEL);
208-
if (!desc)
209-
return -ENOMEM;
210-
207+
desc = &data->desc;
211208
desc->ops = &rockchip_dfi_ops;
212209
desc->driver_data = data;
213210
desc->name = np->name;
214-
data->desc = desc;
215211

216212
data->edev = devm_devfreq_event_add_edev(&pdev->dev, desc);
217213
if (IS_ERR(data->edev)) {

0 commit comments

Comments
 (0)