Commit bc0b828
Revert "PCI: Avoid reset when disabled via sysfs"
This reverts commit 479380e.
The reset_method attribute on a PCI device is only intended to manage the
availability of function scoped resets for a device. It was never intended
to restrict resets targeting the bus or slot.
In introducing a restriction that each device must support function level
reset by testing pci_reset_supported(), we essentially create a catch-22,
that a device must have a function scope reset in order to support bus/slot
reset, when we use bus/slot reset to effect a reset of a device that does
not support a function scoped reset, especially multi-function devices.
This breaks the majority of uses cases where vfio-pci uses bus/slot resets
to manage multifunction devices that do not support function scoped resets.
Fixes: 479380e ("PCI: Avoid reset when disabled via sysfs")
Reported-by: Cal Peake <cp@absolutedigital.net>
Closes: https://lore.kernel.org/all/808e1111-27b7-f35b-6d5c-5b275e73677b@absolutedigital.net
Reported-by: Athul Krishna <athul.krishna.kr@protonmail.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220010
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20250414211828.3530741-1-alex.williamson@redhat.com1 parent 0af2f6b commit bc0b828
1 file changed
Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5429 | 5429 | | |
5430 | 5430 | | |
5431 | 5431 | | |
5432 | | - | |
5433 | | - | |
5434 | 5432 | | |
5435 | 5433 | | |
5436 | 5434 | | |
| |||
5507 | 5505 | | |
5508 | 5506 | | |
5509 | 5507 | | |
5510 | | - | |
5511 | | - | |
5512 | 5508 | | |
5513 | 5509 | | |
5514 | 5510 | | |
| |||
0 commit comments