printk/index: Fix -Wunused-function warning

YueHaibing · pmladek · commit bc17bed5fd73 · 2021-08-27T16:42:44.000+02:00
If CONFIG_MODULES is n, we got this: kernel/printk/index.c:146:13: warning: ‘pi_remove_file’ defined but not used [-Wunused-function] Move it inside #ifdef block to fix this warning. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> Signed-off-by: Petr Mladek <pmladek@suse.com> Link: https://lore.kernel.org/r/20210804130105.18732-1-yuehaibing@huawei.com
diff --git a/kernel/printk/index.c b/kernel/printk/index.c
@@ -143,12 +143,12 @@ static void pi_create_file(struct module *mod)
 				       mod, &dfs_index_fops);
 }
 
+#ifdef CONFIG_MODULES
 static void pi_remove_file(struct module *mod)
 {
 	debugfs_remove(debugfs_lookup(pi_get_module_name(mod), dfs_index));
 }
 
-#ifdef CONFIG_MODULES
 static int pi_module_notify(struct notifier_block *nb, unsigned long op,
 			    void *data)
 {

Original file line number	Diff line number	Diff line change
`@@ -143,12 +143,12 @@ static void pi_create_file(struct module *mod)`
`143`	`143`	`mod, &dfs_index_fops);`
`144`	`144`	`}`
`145`	`145`
	`146`	`+#ifdef CONFIG_MODULES`
`146`	`147`	`static void pi_remove_file(struct module *mod)`
`147`	`148`	`{`
`148`	`149`	`debugfs_remove(debugfs_lookup(pi_get_module_name(mod), dfs_index));`
`149`	`150`	`}`
`150`	`151`
`151`		`-#ifdef CONFIG_MODULES`
`152`	`152`	`static int pi_module_notify(struct notifier_block *nb, unsigned long op,`
`153`	`153`	`void *data)`
`154`	`154`	`{`