nfsd: fix file memleak on client_opens_release

mngyadam · chucklever · commit bc1b5acb4020 · 2023-11-17T15:12:39.000-05:00
seq_release should be called to free the allocated seq_file Cc: stable@vger.kernel.org # v5.3+ Signed-off-by: Mahmoud Adam <mngyadam@amazon.com> Reviewed-by: Jeff Layton <jlayton@kernel.org> Fixes: 78599c4 ("nfsd4: add file to display list of client's opens") Reviewed-by: NeilBrown <neilb@suse.de> Tested-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
@@ -2804,7 +2804,7 @@ static int client_opens_release(struct inode *inode, struct file *file)
 
 	/* XXX: alternatively, we could get/drop in seq start/stop */
 	drop_client(clp);
-	return 0;
+	return seq_release(inode, file);
 }
 
 static const struct file_operations client_states_fops = {

Original file line number	Diff line number	Diff line change
`@@ -2804,7 +2804,7 @@ static int client_opens_release(struct inode inode, struct file file)`
`2804`	`2804`
`2805`	`2805`	`/* XXX: alternatively, we could get/drop in seq start/stop */`
`2806`	`2806`	`drop_client(clp);`
`2807`		`- return 0;`
	`2807`	`+ return seq_release(inode, file);`
`2808`	`2808`	`}`
`2809`	`2809`
`2810`	`2810`	`static const struct file_operations client_states_fops = {`