Skip to content

Commit bcbcf50

Browse files
committed
kbuild: fix ld-version.sh to not be affected by locale
ld-version.sh checks the output from $(LD) --version, but it has a problem on some locales. For example, in Italian: $ LC_MESSAGES=it_IT.UTF-8 ld --version | head -n 1 ld di GNU (GNU Binutils for Debian) 2.35.2 This makes ld-version.sh fail because it expects "GNU ld" for the BFD linker case. Add LC_ALL=C to override the user's locale. BTW, setting LC_MESSAGES=C (or LANG=C) is not enough because it is ineffective if LC_ALL is set on the user's environment. Link: https://bugzilla.kernel.org/show_bug.cgi?id=212105 Reported-by: Marco Scardovi Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Recensito-da: Nick Desaulniers <ndesaulniers@google.com> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
1 parent 285a65f commit bcbcf50

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

scripts/ld-version.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ orig_args="$@"
2929
# Get the first line of the --version output.
3030
IFS='
3131
'
32-
set -- $("$@" --version)
32+
set -- $(LC_ALL=C "$@" --version)
3333

3434
# Split the line on spaces.
3535
IFS=' '

0 commit comments

Comments
 (0)