Skip to content

Commit bce81fe

Browse files
JoseExpositopH5
authored andcommitted
drm/imx: Fix memory leak in imx_pd_connector_get_modes
Avoid leaking the display mode variable if of_get_drm_display_mode fails. Fixes: 76ecd9c ("drm/imx: parallel-display: check return code from of_get_drm_display_mode()") Addresses-Coverity-ID: 1443943 ("Resource leak") Signed-off-by: José Expósito <jose.exposito89@gmail.com> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de> Link: https://lore.kernel.org/r/20220108165230.44610-1-jose.exposito89@gmail.com
1 parent 8027a9a commit bce81fe

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/gpu/drm/imx/parallel-display.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,10 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector)
7575
ret = of_get_drm_display_mode(np, &imxpd->mode,
7676
&imxpd->bus_flags,
7777
OF_USE_NATIVE_MODE);
78-
if (ret)
78+
if (ret) {
79+
drm_mode_destroy(connector->dev, mode);
7980
return ret;
81+
}
8082

8183
drm_mode_copy(mode, &imxpd->mode);
8284
mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;

0 commit comments

Comments
 (0)