Skip to content

Commit bd05aeb

Browse files
committed
coredump: avoid pointless cred reference count bump
The creds are allocated via prepare_creds() which has already taken a reference. Link: https://lore.kernel.org/r/20241125-work-cred-v2-12-68b9d38bb5b2@kernel.org Reviewed-by: Jeff Layton <jlayton@kernel.org> Reviewed-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent caf6bf4 commit bd05aeb

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

fs/coredump.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ void do_coredump(const kernel_siginfo_t *siginfo)
576576
if (retval < 0)
577577
goto fail_creds;
578578

579-
old_cred = override_creds(get_new_cred(cred));
579+
old_cred = override_creds(cred);
580580

581581
ispipe = format_corename(&cn, &cprm, &argv, &argc);
582582

@@ -781,7 +781,7 @@ void do_coredump(const kernel_siginfo_t *siginfo)
781781
kfree(argv);
782782
kfree(cn.corename);
783783
coredump_finish(core_dumped);
784-
put_cred(revert_creds(old_cred));
784+
revert_creds(old_cred);
785785
fail_creds:
786786
put_cred(cred);
787787
fail:

0 commit comments

Comments
 (0)