Skip to content

Commit bd43a98

Browse files
tq-steinasuperna9999
authored andcommitted
drm: bridge: ldb: Warn if LDB clock does not match requested link frequency
The LDB clock needs to be exactly 7-times the pixel clock used by the display. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20221208065538.1753666-1-alexander.stein@ew.tq-group.com
1 parent ae5a8dc commit bd43a98

1 file changed

Lines changed: 19 additions & 4 deletions

File tree

drivers/gpu/drm/bridge/fsl-ldb.c

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,14 @@ static inline struct fsl_ldb *to_fsl_ldb(struct drm_bridge *bridge)
6666
return container_of(bridge, struct fsl_ldb, bridge);
6767
}
6868

69+
static unsigned long fsl_ldb_link_frequency(struct fsl_ldb *fsl_ldb, int clock)
70+
{
71+
if (fsl_ldb->lvds_dual_link)
72+
return clock * 3500;
73+
else
74+
return clock * 7000;
75+
}
76+
6977
static int fsl_ldb_attach(struct drm_bridge *bridge,
7078
enum drm_bridge_attach_flags flags)
7179
{
@@ -85,6 +93,8 @@ static void fsl_ldb_atomic_enable(struct drm_bridge *bridge,
8593
const struct drm_display_mode *mode;
8694
struct drm_connector *connector;
8795
struct drm_crtc *crtc;
96+
unsigned long configured_link_freq;
97+
unsigned long requested_link_freq;
8898
bool lvds_format_24bpp;
8999
bool lvds_format_jeida;
90100
u32 reg;
@@ -128,10 +138,15 @@ static void fsl_ldb_atomic_enable(struct drm_bridge *bridge,
128138
crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
129139
mode = &crtc_state->adjusted_mode;
130140

131-
if (fsl_ldb->lvds_dual_link)
132-
clk_set_rate(fsl_ldb->clk, mode->clock * 3500);
133-
else
134-
clk_set_rate(fsl_ldb->clk, mode->clock * 7000);
141+
requested_link_freq = fsl_ldb_link_frequency(fsl_ldb, mode->clock);
142+
clk_set_rate(fsl_ldb->clk, requested_link_freq);
143+
144+
configured_link_freq = clk_get_rate(fsl_ldb->clk);
145+
if (configured_link_freq != requested_link_freq)
146+
dev_warn(fsl_ldb->dev, "Configured LDB clock (%lu Hz) does not match requested LVDS clock: %lu Hz",
147+
configured_link_freq,
148+
requested_link_freq);
149+
135150
clk_prepare_enable(fsl_ldb->clk);
136151

137152
/* Program LDB_CTRL */

0 commit comments

Comments
 (0)