Skip to content

Commit bd71cdd

Browse files
committed
drm/xe: Clear all snapshot members after deleting coredump
It's not strictly needed to clear right now, but this prevents bugs from dangling pointers. Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Reviewed-by: Francois Dugast <francois.dugast@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240221133024.898315-2-maarten.lankhorst@linux.intel.com
1 parent 8491b0e commit bd71cdd

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/gpu/drm/xe/xe_devcoredump.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,8 @@ static void xe_devcoredump_free(void *data)
124124
if (coredump->snapshot.hwe[i])
125125
xe_hw_engine_snapshot_free(coredump->snapshot.hwe[i]);
126126

127+
/* To prevent stale data on next snapshot, clear everything */
128+
memset(&coredump->snapshot, 0, sizeof(coredump->snapshot));
127129
coredump->captured = false;
128130
drm_info(&coredump_to_xe(coredump)->drm,
129131
"Xe device coredump has been deleted.\n");

0 commit comments

Comments
 (0)