Skip to content

Commit bdcdf96

Browse files
author
Thomas Hellström
committed
drm, drm/xe: Fix xe userptr in the absence of CONFIG_DEVICE_PRIVATE
CONFIG_DEVICE_PRIVATE is not selected by default by some distros, for example Fedora, and that leads to a regression in the xe driver since userptr support gets compiled out. It turns out that DRM_GPUSVM, which is needed for xe userptr support compiles also without CONFIG_DEVICE_PRIVATE, but doesn't compile without CONFIG_ZONE_DEVICE. Exclude the drm_pagemap files from compilation with !CONFIG_ZONE_DEVICE, and remove the CONFIG_DEVICE_PRIVATE dependency from CONFIG_DRM_GPUSVM and the xe driver's selection of it, re-enabling xe userptr for those configs. v2: - Don't compile the drm_pagemap files unless CONFIG_ZONE_DEVICE is set. - Adjust the drm_pagemap.h header accordingly. Fixes: 9e97874 ("drm/xe/userptr: replace xe_hmm with gpusvm") Cc: Matthew Auld <matthew.auld@intel.com> Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com> Cc: Matthew Brost <matthew.brost@intel.com> Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: dri-devel@lists.freedesktop.org Cc: <stable@vger.kernel.org> # v6.18+ Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> Reviewed-by: Matthew Auld <matthew.auld@intel.com> Acked-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Link: https://patch.msgid.link/20260121091048.41371-2-thomas.hellstrom@linux.intel.com (cherry picked from commit 1e372b2) Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
1 parent f262015 commit bdcdf96

4 files changed

Lines changed: 22 additions & 5 deletions

File tree

drivers/gpu/drm/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ config DRM_GPUVM
210210

211211
config DRM_GPUSVM
212212
tristate
213-
depends on DRM && DEVICE_PRIVATE
213+
depends on DRM
214214
select HMM_MIRROR
215215
select MMU_NOTIFIER
216216
help

drivers/gpu/drm/Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,10 @@ obj-$(CONFIG_DRM_EXEC) += drm_exec.o
108108
obj-$(CONFIG_DRM_GPUVM) += drm_gpuvm.o
109109

110110
drm_gpusvm_helper-y := \
111-
drm_gpusvm.o\
111+
drm_gpusvm.o
112+
drm_gpusvm_helper-$(CONFIG_ZONE_DEVICE) += \
112113
drm_pagemap.o
114+
113115
obj-$(CONFIG_DRM_GPUSVM) += drm_gpusvm_helper.o
114116

115117
obj-$(CONFIG_DRM_BUDDY) += drm_buddy.o

drivers/gpu/drm/xe/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ config DRM_XE
3939
select DRM_TTM
4040
select DRM_TTM_HELPER
4141
select DRM_EXEC
42-
select DRM_GPUSVM if !UML && DEVICE_PRIVATE
42+
select DRM_GPUSVM if !UML
4343
select DRM_GPUVM
4444
select DRM_SCHED
4545
select MMU_NOTIFIER

include/drm/drm_pagemap.h

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,19 @@ struct drm_pagemap_devmem_ops {
209209
struct dma_fence *pre_migrate_fence);
210210
};
211211

212+
#if IS_ENABLED(CONFIG_ZONE_DEVICE)
213+
214+
struct drm_pagemap *drm_pagemap_page_to_dpagemap(struct page *page);
215+
216+
#else
217+
218+
static inline struct drm_pagemap *drm_pagemap_page_to_dpagemap(struct page *page)
219+
{
220+
return NULL;
221+
}
222+
223+
#endif /* IS_ENABLED(CONFIG_ZONE_DEVICE) */
224+
212225
/**
213226
* struct drm_pagemap_devmem - Structure representing a GPU SVM device memory allocation
214227
*
@@ -233,6 +246,8 @@ struct drm_pagemap_devmem {
233246
struct dma_fence *pre_migrate_fence;
234247
};
235248

249+
#if IS_ENABLED(CONFIG_ZONE_DEVICE)
250+
236251
int drm_pagemap_migrate_to_devmem(struct drm_pagemap_devmem *devmem_allocation,
237252
struct mm_struct *mm,
238253
unsigned long start, unsigned long end,
@@ -243,8 +258,6 @@ int drm_pagemap_evict_to_ram(struct drm_pagemap_devmem *devmem_allocation);
243258

244259
const struct dev_pagemap_ops *drm_pagemap_pagemap_ops_get(void);
245260

246-
struct drm_pagemap *drm_pagemap_page_to_dpagemap(struct page *page);
247-
248261
void drm_pagemap_devmem_init(struct drm_pagemap_devmem *devmem_allocation,
249262
struct device *dev, struct mm_struct *mm,
250263
const struct drm_pagemap_devmem_ops *ops,
@@ -256,4 +269,6 @@ int drm_pagemap_populate_mm(struct drm_pagemap *dpagemap,
256269
struct mm_struct *mm,
257270
unsigned long timeslice_ms);
258271

272+
#endif /* IS_ENABLED(CONFIG_ZONE_DEVICE) */
273+
259274
#endif

0 commit comments

Comments
 (0)