Skip to content

Commit bdff938

Browse files
Davidlohr Buesorafaeljw
authored andcommitted
thermal: int340x: Clean up unnecessary acpi_buffer pointer freeing
It is the caller's responsibility to free only upon ACPI_SUCCESS. Signed-off-by: Davidlohr Bueso <dave@stgolabs.net> Acked-by: Zhang Rui <rui.zhang@intel.com> [ rjw: Subject edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 3123109 commit bdff938

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/thermal/intel/int340x_thermal/int3400_thermal.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,11 +186,11 @@ static int int3400_thermal_run_osc(acpi_handle handle, char *uuid_str, int *enab
186186
ret = *((u32 *)(context.ret.pointer + 4));
187187
if (ret != *enable)
188188
result = -EPERM;
189+
190+
kfree(context.ret.pointer);
189191
} else
190192
result = -EPERM;
191193

192-
kfree(context.ret.pointer);
193-
194194
return result;
195195
}
196196

0 commit comments

Comments
 (0)