Skip to content

Commit be03b06

Browse files
ij-intelgregkh
authored andcommitted
serial: 8250: Store to lsr_save_flags after lsr read
Not all LSR register flags are preserved across reads. Therefore, LSR readers must store the non-preserved bits into lsr_save_flags. This fix was initially mixed into feature commit f6f5861 ("serial: 8250: Handle UART without interrupt on TEMT using em485"). However, that feature change had a flaw and it was reverted to make room for simpler approach providing the same feature. The embedded fix got reverted with the feature change. Re-add the lsr_save_flags fix and properly mark it's a fix. Link: https://lore.kernel.org/all/1d6c31d-d194-9e6a-ddf9-5f29af829f3@linux.intel.com/T/#m1737eef986bd20cf19593e344cebd7b0244945fc Fixes: e490c91 ("tty: Add software emulated RS485 support for 8250") Cc: stable <stable@kernel.org> Acked-by: Uwe Kleine-König <u.kleine-koenig@penugtronix.de> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Link: https://lore.kernel.org/r/f4d774be-1437-a550-8334-19d8722ab98c@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 499e13a commit be03b06

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

drivers/tty/serial/8250/8250_port.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1517,6 +1517,8 @@ static inline void __stop_tx(struct uart_8250_port *p)
15171517
unsigned char lsr = serial_in(p, UART_LSR);
15181518
u64 stop_delay = 0;
15191519

1520+
p->lsr_saved_flags |= lsr & LSR_SAVE_FLAGS;
1521+
15201522
if (!(lsr & UART_LSR_THRE))
15211523
return;
15221524
/*

0 commit comments

Comments
 (0)