media: pci: cx18: if cx == NULL, then don't use it.

Hans Verkuil · Hans Verkuil · commit be521bf7bfad · 2023-10-13T11:33:22.000+02:00
If the cx NULL pointer check is true, then it reports
an error with CX18_ERR, but that uses cx. Replace it with
pr_err.

Reported by smatch:

drivers/media/pci/cx18/cx18-mailbox.c:834 cx18_vapi() error: we previously assumed 'cx' could be null (see line 833)

Signed-off-by: Hans Verkuil &lt;hverkuil-cisco@xs4all.nl&gt;
diff --git a/drivers/media/pci/cx18/cx18-mailbox.c b/drivers/media/pci/cx18/cx18-mailbox.c
@@ -831,7 +831,7 @@ int cx18_vapi(struct cx18 *cx, u32 cmd, int args, ...)
 	int i;
 
 	if (cx == NULL) {
-		CX18_ERR("cx == NULL (cmd=%x)\n", cmd);
+		pr_err("cx == NULL (cmd=%x)\n", cmd);
 		return 0;
 	}
 	if (args > MAX_MB_ARGUMENTS) {

Original file line number	Diff line number	Diff line change
`@@ -831,7 +831,7 @@ int cx18_vapi(struct cx18 *cx, u32 cmd, int args, ...)`
`831`	`831`	`int i;`
`832`	`832`
`833`	`833`	`if (cx == NULL) {`
`834`		`- CX18_ERR("cx == NULL (cmd=%x)\n", cmd);`
	`834`	`+ pr_err("cx == NULL (cmd=%x)\n", cmd);`
`835`	`835`	`return 0;`
`836`	`836`	`}`
`837`	`837`	`if (args > MAX_MB_ARGUMENTS) {`