Skip to content

Commit be82fdd

Browse files
captain5050acmel
authored andcommitted
libperf tests: Avoid uninitialized variable warning
The variable 'bf' is read (for a write call) without being initialized triggering a memory sanitizer warning. Use 'bf' in the read and switch the write to reading from a string. Signed-off-by: Ian Rogers <irogers@google.com> Acked-by: Jiri Olsa <jolsa@redhat.com> Acked-by: Namhyung Kim <namhyung@kernel.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lore.kernel.org/lkml/20210114212304.4018119-1-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent a042a82 commit be82fdd

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tools/lib/perf/tests/test-evlist.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,6 @@ static int test_mmap_thread(void)
208208
char path[PATH_MAX];
209209
int id, err, pid, go_pipe[2];
210210
union perf_event *event;
211-
char bf;
212211
int count = 0;
213212

214213
snprintf(path, PATH_MAX, "%s/kernel/debug/tracing/events/syscalls/sys_enter_prctl/id",
@@ -229,6 +228,7 @@ static int test_mmap_thread(void)
229228
pid = fork();
230229
if (!pid) {
231230
int i;
231+
char bf;
232232

233233
read(go_pipe[0], &bf, 1);
234234

@@ -266,7 +266,7 @@ static int test_mmap_thread(void)
266266
perf_evlist__enable(evlist);
267267

268268
/* kick the child and wait for it to finish */
269-
write(go_pipe[1], &bf, 1);
269+
write(go_pipe[1], "A", 1);
270270
waitpid(pid, NULL, 0);
271271

272272
/*

0 commit comments

Comments
 (0)