Skip to content

Commit be90c7b

Browse files
q2venkuba-moo
authored andcommitted
selftest: packetdrill: Refine tcp_fastopen_server_reset-after-disconnect.pkt.
These changes are applied to follow the imported packetdrill tests. * Call setsockopt(TCP_FASTOPEN) * Remove unnecessary accept() delay * Add assertion for TCP states * Rename to tcp_fastopen_server_trigger-rst-reconnect.pkt. Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com> Reviewed-by: Willem de Bruijn <willemb@google.com> Link: https://patch.msgid.link/20250927213022.1850048-12-kuniyu@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 21f7fb3 commit be90c7b

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

tools/testing/selftests/net/packetdrill/tcp_fastopen_server_reset-after-disconnect.pkt renamed to tools/testing/selftests/net/packetdrill/tcp_fastopen_server_trigger-rst-reconnect.pkt

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,30 @@
11
// SPDX-License-Identifier: GPL-2.0
22
`./defaults.sh
3-
./set_sysctls.py /proc/sys/net/ipv4/tcp_fastopen=0x602 /proc/sys/net/ipv4/tcp_timestamps=0`
3+
./set_sysctls.py /proc/sys/net/ipv4/tcp_timestamps=0`
44

55
0 socket(..., SOCK_STREAM|SOCK_NONBLOCK, IPPROTO_TCP) = 3
66
+0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0
77
+0 bind(3, ..., ...) = 0
88
+0 listen(3, 1) = 0
9+
+0 setsockopt(3, SOL_TCP, TCP_FASTOPEN, [1], 4) = 0
910

10-
+0 < S 0:10(10) win 32792 <mss 1460,nop,nop,sackOK>
11+
+0 < S 0:10(10) win 32792 <mss 1460,nop,nop,sackOK,nop,nop,FO TFO_COOKIE>
1112
+0 > S. 0:0(0) ack 11 win 65535 <mss 1460,nop,nop,sackOK>
1213

1314
// sk->sk_state is TCP_SYN_RECV
14-
+.1 accept(3, ..., ...) = 4
15+
+0 accept(3, ..., ...) = 4
16+
+0 %{ assert tcpi_state == TCP_SYN_RECV, tcpi_state }%
1517

1618
// tcp_disconnect() sets sk->sk_state to TCP_CLOSE
1719
+0 connect(4, AF_UNSPEC, ...) = 0
1820
+0 > R. 1:1(0) ack 11 win 65535
21+
+0 %{ assert tcpi_state == TCP_CLOSE, tcpi_state }%
1922

2023
// connect() sets sk->sk_state to TCP_SYN_SENT
2124
+0 fcntl(4, F_SETFL, O_RDWR|O_NONBLOCK) = 0
2225
+0 connect(4, ..., ...) = -1 EINPROGRESS (Operation is now in progress)
2326
+0 > S 0:0(0) win 65535 <mss 1460,nop,nop,sackOK,nop,wscale 8>
27+
+0 %{ assert tcpi_state == TCP_SYN_SENT, tcpi_state }%
2428

2529
// tp->fastopen_rsk must be NULL
2630
+1 > S 0:0(0) win 65535 <mss 1460,nop,nop,sackOK,nop,wscale 8>

0 commit comments

Comments
 (0)