assoc_array: fix the return value in assoc_array_insert_mid_shortcut()

RSmirnov512 · akpm00 · commit bea0a5869587 · 2024-03-12T13:09:23.000-07:00
Returning the edit variable is redundant because it is dereferenced right before it is returned. It would be better to return true. Found by Linux Verification Center (linuxtesting.org) with Svace. Link: https://lkml.kernel.org/r/20240307071717.5318-1-r.smirnov@omp.ru Signed-off-by: Roman Smirnov <r.smirnov@omp.ru> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
diff --git a/lib/assoc_array.c b/lib/assoc_array.c
@@ -938,7 +938,7 @@ static bool assoc_array_insert_mid_shortcut(struct assoc_array_edit *edit,
 		edit->leaf_p = &new_n0->slots[0];
 
 	pr_devel("<--%s() = ok [split shortcut]\n", __func__);
-	return edit;
+	return true;
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -938,7 +938,7 @@ static bool assoc_array_insert_mid_shortcut(struct assoc_array_edit *edit,`
`938`	`938`	`edit->leaf_p = &new_n0->slots[0];`
`939`	`939`
`940`	`940`	`pr_devel("<--%s() = ok [split shortcut]\n", __func__);`
`941`		`- return edit;`
	`941`	`+ return true;`
`942`	`942`	`}`
`943`	`943`
`944`	`944`	`/**`