Skip to content

Commit bec4d7c

Browse files
Dan Carpenterwesteri
authored andcommitted
thunderbolt: Fix a leak in tb_retimer_add()
After the device_register() succeeds, then the correct way to clean up is to call device_unregister(). The unregister calls both device_del() and device_put(). Since this code was only device_del() it results in a memory leak. Fixes: dacb128 ("thunderbolt: Add support for on-board retimers") Cc: stable@vger.kernel.org Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
1 parent a5e13c6 commit bec4d7c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/thunderbolt/retimer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ static int tb_retimer_add(struct tb_port *port, u8 index, u32 auth_status)
347347
ret = tb_retimer_nvm_add(rt);
348348
if (ret) {
349349
dev_err(&rt->dev, "failed to add NVM devices: %d\n", ret);
350-
device_del(&rt->dev);
350+
device_unregister(&rt->dev);
351351
return ret;
352352
}
353353

0 commit comments

Comments
 (0)