PCI: endpoint: Fix misused goto label

FirstLoveLife · Lorenzo Pieralisi · commit bf8d87c076f5 · 2022-03-07T11:42:12.000Z
Fix a misused goto label jump since that can result in a memory leak. Link: https://lore.kernel.org/r/17e7b9b9ee6.c6d9c6a02564.4545388417402742326@zohomail.com Signed-off-by: Li Chen <lchen@ambarella.com> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c
@@ -451,7 +451,7 @@ static int pci_epf_test_write(struct pci_epf_test *epf_test)
 		if (!epf_test->dma_supported) {
 			dev_err(dev, "Cannot transfer data using DMA\n");
 			ret = -EINVAL;
-			goto err_map_addr;
+			goto err_dma_map;
 		}
 
 		src_phys_addr = dma_map_single(dma_dev, buf, reg->size,

Original file line number	Diff line number	Diff line change
`@@ -451,7 +451,7 @@ static int pci_epf_test_write(struct pci_epf_test *epf_test)`
`451`	`451`	`if (!epf_test->dma_supported) {`
`452`	`452`	`dev_err(dev, "Cannot transfer data using DMA\n");`
`453`	`453`	`ret = -EINVAL;`
`454`		`- goto err_map_addr;`
	`454`	`+ goto err_dma_map;`
`455`	`455`	`}`
`456`	`456`
`457`	`457`	`src_phys_addr = dma_map_single(dma_dev, buf, reg->size,`