bcachefs: Fix ref leak in write_super()

Kent Overstreet · Kent Overstreet · commit bfbb76ec9808 · 2025-04-20T19:41:38.000-04:00
found with the new enumerated_ref code

Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/super-io.c b/fs/bcachefs/super-io.c
@@ -1102,7 +1102,8 @@ int bch2_write_super(struct bch_fs *c)
 		prt_str(&buf, ")");
 		bch2_fs_fatal_error(c, ": %s", buf.buf);
 		printbuf_exit(&buf);
-		return -BCH_ERR_sb_not_downgraded;
+		ret = -BCH_ERR_sb_not_downgraded;
+		goto out;
 	}
 
 	darray_for_each(online_devices, ca) {

Original file line number	Diff line number	Diff line change
`@@ -1102,7 +1102,8 @@ int bch2_write_super(struct bch_fs *c)`
`1102`	`1102`	`prt_str(&buf, ")");`
`1103`	`1103`	`bch2_fs_fatal_error(c, ": %s", buf.buf);`
`1104`	`1104`	`printbuf_exit(&buf);`
`1105`		`- return -BCH_ERR_sb_not_downgraded;`
	`1105`	`+ ret = -BCH_ERR_sb_not_downgraded;`
	`1106`	`+ goto out;`
`1106`	`1107`	`}`
`1107`	`1108`
`1108`	`1109`	`darray_for_each(online_devices, ca) {`