Skip to content

Commit bfd08d0

Browse files
andy-shevgregkh
authored andcommitted
USB: gadget: u_f: Unbreak offset calculation in VLAs
Inadvertently the commit b1cd1b6 ("USB: gadget: u_f: add overflow checks to VLA macros") makes VLA macros to always return 0 due to different scope of two variables of the same name. Obviously we need to have only one. Fixes: b1cd1b6 ("USB: gadget: u_f: add overflow checks to VLA macros") Reported-by: Marek Szyprowski <m.szyprowski@samsung.com> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Brooke Basile <brookebasile@gmail.com> Cc: stable <stable@kernel.org> Link: https://lore.kernel.org/r/20200826192119.56450-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 068834a commit bfd08d0

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

drivers/usb/gadget/u_f.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@
2525
size_t offset = 0; \
2626
if (groupname##__next != SIZE_MAX) { \
2727
size_t align_mask = __alignof__(type) - 1; \
28-
size_t offset = (groupname##__next + align_mask) \
29-
& ~align_mask; \
3028
size_t size = array_size(n, sizeof(type)); \
29+
offset = (groupname##__next + align_mask) & \
30+
~align_mask; \
3131
if (check_add_overflow(offset, size, \
3232
&groupname##__next)) { \
3333
groupname##__next = SIZE_MAX; \
@@ -43,8 +43,8 @@
4343
size_t offset = 0; \
4444
if (groupname##__next != SIZE_MAX) { \
4545
size_t align_mask = __alignof__(type) - 1; \
46-
size_t offset = (groupname##__next + align_mask) \
47-
& ~align_mask; \
46+
offset = (groupname##__next + align_mask) & \
47+
~align_mask; \
4848
if (check_add_overflow(offset, groupname##_##name##__sz,\
4949
&groupname##__next)) { \
5050
groupname##__next = SIZE_MAX; \

0 commit comments

Comments
 (0)