Skip to content

Commit c039459

Browse files
ribaldamchehab
authored andcommitted
media: stb0899: Simplify check
chip_id is an unsigned number, it can never be < 0 Fixes cocci check: drivers/media/dvb-frontends/stb0899_drv.c:1280:8-15: WARNING: Unsigned expression compared with zero: chip_id > 0 Link: https://lore.kernel.org/linux-media/20240429-fix-cocci-v3-2-3c4865f5a4b0@chromium.org Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
1 parent ff924ca commit c039459

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/media/dvb-frontends/stb0899_drv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1277,7 +1277,7 @@ static int stb0899_get_dev_id(struct stb0899_state *state)
12771277
dprintk(state->verbose, FE_ERROR, 1, "Demodulator Core ID=[%s], Version=[%d]", (char *) &demod_str, demod_ver);
12781278
CONVERT32(STB0899_READ_S2REG(STB0899_S2FEC, FEC_CORE_ID_REG), (char *)&fec_str);
12791279
fec_ver = STB0899_READ_S2REG(STB0899_S2FEC, FEC_VER_ID_REG);
1280-
if (! (chip_id > 0)) {
1280+
if (!chip_id) {
12811281
dprintk(state->verbose, FE_ERROR, 1, "couldn't find a STB 0899");
12821282

12831283
return -ENODEV;

0 commit comments

Comments
 (0)