dmaengine: ti: Fix refcount leak in ti_dra7_xbar_route_allocate

Yuuoniy · vinodkoul · commit c132fe78ad7b · 2022-06-09T11:30:30.000+05:30
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not needed anymore. Add missing of_node_put() in to fix this. Fixes: ec9bfa1 ("dmaengine: ti-dma-crossbar: dra7: Use bitops instead of idr") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Link: https://lore.kernel.org/r/20220605042723.17668-2-linmq006@gmail.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
@@ -268,6 +268,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
 		mutex_unlock(&xbar->mutex);
 		dev_err(&pdev->dev, "Run out of free DMA requests\n");
 		kfree(map);
+		of_node_put(dma_spec->np);
 		return ERR_PTR(-ENOMEM);
 	}
 	set_bit(map->xbar_out, xbar->dma_inuse);

Original file line number	Diff line number	Diff line change
`@@ -268,6 +268,7 @@ static void ti_dra7_xbar_route_allocate(struct of_phandle_args dma_spec,`
`268`	`268`	`mutex_unlock(&xbar->mutex);`
`269`	`269`	`dev_err(&pdev->dev, "Run out of free DMA requests\n");`
`270`	`270`	`kfree(map);`
	`271`	`+ of_node_put(dma_spec->np);`
`271`	`272`	`return ERR_PTR(-ENOMEM);`
`272`	`273`	`}`
`273`	`274`	`set_bit(map->xbar_out, xbar->dma_inuse);`