Skip to content

Commit c158f98

Browse files
RajuRangojukuba-moo
authored andcommitted
amd-xgbe: avoid misleading per-packet error log
On the receive path, packet can be damaged because of buffer overflow in Rx FIFO. Avoid misleading per-packet error log when packet->errors is set, this can flood the log. Instead, rely on the standard rtnl_link_stats64 stats. Fixes: c5aa9e3 ("amd-xgbe: Initial AMD 10GbE platform driver") Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com> Link: https://patch.msgid.link/20260114163037.2062606-1-Raju.Rangoju@amd.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent d998b0e commit c158f98

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

drivers/net/ethernet/amd/xgbe/xgbe-drv.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1837,7 +1837,7 @@ static void xgbe_get_stats64(struct net_device *netdev,
18371837
s->multicast = pstats->rxmulticastframes_g;
18381838
s->rx_length_errors = pstats->rxlengtherror;
18391839
s->rx_crc_errors = pstats->rxcrcerror;
1840-
s->rx_fifo_errors = pstats->rxfifooverflow;
1840+
s->rx_over_errors = pstats->rxfifooverflow;
18411841

18421842
s->tx_packets = pstats->txframecount_gb;
18431843
s->tx_bytes = pstats->txoctetcount_gb;
@@ -2292,9 +2292,6 @@ static int xgbe_rx_poll(struct xgbe_channel *channel, int budget)
22922292
goto read_again;
22932293

22942294
if (error || packet->errors) {
2295-
if (packet->errors)
2296-
netif_err(pdata, rx_err, netdev,
2297-
"error in received packet\n");
22982295
dev_kfree_skb(skb);
22992296
goto next_packet;
23002297
}

0 commit comments

Comments
 (0)