Skip to content

Commit c199f64

Browse files
Vasily Gorbikjpoimboe
authored andcommitted
instrumentation.h: Avoid using inline asm operand modifiers
The expansion of instrumentation_begin/instrumentation_end on s390 will result in a compiler error if the __COUNTER__ value is high enough. For example with "i" (154) the "%c0" operand of annotate_reachable will be expanded to -102: -102: .pushsection .discard.instr_begin .long -102b - . .popsection This is a quirk of the gcc backend for s390, it interprets the %c0 as a signed byte value. Avoid using operand modifiers in this case by simply converting __COUNTER__ to string, with the same result, but in an arch assembler independent way. Signed-off-by: Vasily Gorbik <gor@linux.ibm.com> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Link: https://lore.kernel.org/r/patch-2.thread-1a26be.git-1a26be80cb18.your-ad-here.call-01621428935-ext-2104@work.hours Cc: Peter Zijlstra <peterz@infradead.org> Cc: Ingo Molnar <mingo@kernel.org> Cc: Miroslav Benes <mbenes@suse.cz> Cc: Borislav Petkov <bp@suse.de> Cc: linux-kernel@vger.kernel.org
1 parent f1069a8 commit c199f64

1 file changed

Lines changed: 12 additions & 8 deletions

File tree

include/linux/instrumentation.h

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,16 @@
44

55
#if defined(CONFIG_DEBUG_ENTRY) && defined(CONFIG_STACK_VALIDATION)
66

7+
#include <linux/stringify.h>
8+
79
/* Begin/end of an instrumentation safe region */
8-
#define instrumentation_begin() ({ \
9-
asm volatile("%c0: nop\n\t" \
10+
#define __instrumentation_begin(c) ({ \
11+
asm volatile(__stringify(c) ": nop\n\t" \
1012
".pushsection .discard.instr_begin\n\t" \
11-
".long %c0b - .\n\t" \
12-
".popsection\n\t" : : "i" (__COUNTER__)); \
13+
".long " __stringify(c) "b - .\n\t" \
14+
".popsection\n\t"); \
1315
})
16+
#define instrumentation_begin() __instrumentation_begin(__COUNTER__)
1417

1518
/*
1619
* Because instrumentation_{begin,end}() can nest, objtool validation considers
@@ -43,12 +46,13 @@
4346
* To avoid this, have _end() be a NOP instruction, this ensures it will be
4447
* part of the condition block and does not escape.
4548
*/
46-
#define instrumentation_end() ({ \
47-
asm volatile("%c0: nop\n\t" \
49+
#define __instrumentation_end(c) ({ \
50+
asm volatile(__stringify(c) ": nop\n\t" \
4851
".pushsection .discard.instr_end\n\t" \
49-
".long %c0b - .\n\t" \
50-
".popsection\n\t" : : "i" (__COUNTER__)); \
52+
".long " __stringify(c) "b - .\n\t" \
53+
".popsection\n\t"); \
5154
})
55+
#define instrumentation_end() __instrumentation_end(__COUNTER__)
5256
#else
5357
# define instrumentation_begin() do { } while(0)
5458
# define instrumentation_end() do { } while(0)

0 commit comments

Comments
 (0)