Skip to content

Commit c1a3f2c

Browse files
committed
NFSD: Remove NFSD_PROC_ARGS_* macros
Clean up. The PROC_ARGS macros were added when I thought that NFSD tracepoints would be reporting endpoint information. However, tracepoints in the RPC server now report transport endpoint information, so in general there's no need for the upper layers to do that any more, and these macros can be retired. Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent 9db0e15 commit c1a3f2c

1 file changed

Lines changed: 9 additions & 19 deletions

File tree

fs/nfsd/trace.h

Lines changed: 9 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -13,22 +13,6 @@
1313
#include "export.h"
1414
#include "nfsfh.h"
1515

16-
#define NFSD_TRACE_PROC_ARG_FIELDS \
17-
__field(unsigned int, netns_ino) \
18-
__field(u32, xid) \
19-
__array(unsigned char, server, sizeof(struct sockaddr_in6)) \
20-
__array(unsigned char, client, sizeof(struct sockaddr_in6))
21-
22-
#define NFSD_TRACE_PROC_ARG_ASSIGNMENTS \
23-
do { \
24-
__entry->netns_ino = SVC_NET(rqstp)->ns.inum; \
25-
__entry->xid = be32_to_cpu(rqstp->rq_xid); \
26-
memcpy(__entry->server, &rqstp->rq_xprt->xpt_local, \
27-
rqstp->rq_xprt->xpt_locallen); \
28-
memcpy(__entry->client, &rqstp->rq_xprt->xpt_remote, \
29-
rqstp->rq_xprt->xpt_remotelen); \
30-
} while (0);
31-
3216
#define NFSD_TRACE_PROC_RES_FIELDS \
3317
__field(unsigned int, netns_ino) \
3418
__field(u32, xid) \
@@ -53,16 +37,22 @@ DECLARE_EVENT_CLASS(nfsd_xdr_err_class,
5337
),
5438
TP_ARGS(rqstp),
5539
TP_STRUCT__entry(
56-
NFSD_TRACE_PROC_ARG_FIELDS
57-
40+
__field(unsigned int, netns_ino)
41+
__field(u32, xid)
5842
__field(u32, vers)
5943
__field(u32, proc)
44+
__sockaddr(server, rqstp->rq_xprt->xpt_locallen)
45+
__sockaddr(client, rqstp->rq_xprt->xpt_remotelen)
6046
),
6147
TP_fast_assign(
62-
NFSD_TRACE_PROC_ARG_ASSIGNMENTS
48+
const struct svc_xprt *xprt = rqstp->rq_xprt;
6349

50+
__entry->netns_ino = xprt->xpt_net->ns.inum;
51+
__entry->xid = be32_to_cpu(rqstp->rq_xid);
6452
__entry->vers = rqstp->rq_vers;
6553
__entry->proc = rqstp->rq_proc;
54+
__assign_sockaddr(server, &xprt->xpt_local, xprt->xpt_locallen);
55+
__assign_sockaddr(client, &xprt->xpt_remote, xprt->xpt_remotelen);
6656
),
6757
TP_printk("xid=0x%08x vers=%u proc=%u",
6858
__entry->xid, __entry->vers, __entry->proc

0 commit comments

Comments
 (0)