Skip to content

Commit c1a9ec7

Browse files
xdarklightkuba-moo
authored andcommitted
net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs
Enable GSWIP_MII_CFG_EN also for internal PHYs to make traffic flow. Without this the PHY link is detected properly and ethtool statistics for TX are increasing but there's no RX traffic coming in. Fixes: 14fceff ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") Suggested-by: Hauke Mehrtens <hauke@hauke-m.de> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Acked-by: Hauke Mehrtens <hauke@hauke-m.de> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent b40f97b commit c1a9ec7

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/net/dsa/lantiq_gswip.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1541,9 +1541,7 @@ static void gswip_phylink_mac_link_up(struct dsa_switch *ds, int port,
15411541
{
15421542
struct gswip_priv *priv = ds->priv;
15431543

1544-
/* Enable the xMII interface only for the external PHY */
1545-
if (interface != PHY_INTERFACE_MODE_INTERNAL)
1546-
gswip_mii_mask_cfg(priv, 0, GSWIP_MII_CFG_EN, port);
1544+
gswip_mii_mask_cfg(priv, 0, GSWIP_MII_CFG_EN, port);
15471545
}
15481546

15491547
static void gswip_get_strings(struct dsa_switch *ds, int port, u32 stringset,

0 commit comments

Comments
 (0)