Skip to content

Commit c1cf87e

Browse files
Nicholas Carbonesalexdeucher
authored andcommitted
Revert "drm/amd/display: Correct hubp GfxVersion verification"
This reverts commit 3303aa6 ("drm/amd/display: Correct hubp GfxVersion verification") Reason for revert: Got blank screen issues while doing PNP Reviewed-by: Joshua Aberback <joshua.aberback@amd.com> Signed-off-by: Nicholas Carbones <Nicholas.Carbones@amd.com> Signed-off-by: Ray Wu <ray.wu@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 1a524d9 commit c1cf87e

3 files changed

Lines changed: 39 additions & 52 deletions

File tree

drivers/gpu/drm/amd/display/dc/hubp/dcn10/dcn10_hubp.c

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -145,26 +145,21 @@ void hubp1_program_tiling(
145145
{
146146
struct dcn10_hubp *hubp1 = TO_DCN10_HUBP(hubp);
147147

148-
ASSERT(info->gfxversion == DcGfxVersion9 || info->gfxversion == DcGfxBase);
149-
150-
if (info->gfxversion == DcGfxVersion9) {
151-
REG_UPDATE_6(DCSURF_ADDR_CONFIG,
152-
NUM_PIPES, log_2(info->gfx9.num_pipes),
153-
NUM_BANKS, log_2(info->gfx9.num_banks),
154-
PIPE_INTERLEAVE, info->gfx9.pipe_interleave,
155-
NUM_SE, log_2(info->gfx9.num_shader_engines),
156-
NUM_RB_PER_SE, log_2(info->gfx9.num_rb_per_se),
157-
MAX_COMPRESSED_FRAGS, log_2(info->gfx9.max_compressed_frags));
158-
159-
REG_UPDATE_4(DCSURF_TILING_CONFIG,
160-
SW_MODE, info->gfx9.swizzle,
161-
META_LINEAR, info->gfx9.meta_linear,
162-
RB_ALIGNED, info->gfx9.rb_aligned,
163-
PIPE_ALIGNED, info->gfx9.pipe_aligned);
164-
} else {
165-
hubp1_clear_tiling(&hubp1->base);
166-
}
167-
148+
ASSERT(info->gfxversion == DcGfxVersion9);
149+
150+
REG_UPDATE_6(DCSURF_ADDR_CONFIG,
151+
NUM_PIPES, log_2(info->gfx9.num_pipes),
152+
NUM_BANKS, log_2(info->gfx9.num_banks),
153+
PIPE_INTERLEAVE, info->gfx9.pipe_interleave,
154+
NUM_SE, log_2(info->gfx9.num_shader_engines),
155+
NUM_RB_PER_SE, log_2(info->gfx9.num_rb_per_se),
156+
MAX_COMPRESSED_FRAGS, log_2(info->gfx9.max_compressed_frags));
157+
158+
REG_UPDATE_4(DCSURF_TILING_CONFIG,
159+
SW_MODE, info->gfx9.swizzle,
160+
META_LINEAR, info->gfx9.meta_linear,
161+
RB_ALIGNED, info->gfx9.rb_aligned,
162+
PIPE_ALIGNED, info->gfx9.pipe_aligned);
168163
}
169164

170165
void hubp1_program_size(

drivers/gpu/drm/amd/display/dc/hubp/dcn20/dcn20_hubp.c

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -313,22 +313,18 @@ static void hubp2_program_tiling(
313313
const struct dc_tiling_info *info,
314314
const enum surface_pixel_format pixel_format)
315315
{
316-
ASSERT(info->gfxversion == DcGfxVersion9 || info->gfxversion == DcGfxBase);
317-
318-
if (info->gfxversion == DcGfxVersion9) {
319-
REG_UPDATE_3(DCSURF_ADDR_CONFIG,
320-
NUM_PIPES, log_2(info->gfx9.num_pipes),
321-
PIPE_INTERLEAVE, info->gfx9.pipe_interleave,
322-
MAX_COMPRESSED_FRAGS, log_2(info->gfx9.max_compressed_frags));
323-
324-
REG_UPDATE_4(DCSURF_TILING_CONFIG,
325-
SW_MODE, info->gfx9.swizzle,
326-
META_LINEAR, 0,
327-
RB_ALIGNED, 0,
328-
PIPE_ALIGNED, 0);
329-
} else {
330-
hubp2_clear_tiling(&hubp2->base);
331-
}
316+
ASSERT(info->gfxversion == DcGfxVersion9);
317+
318+
REG_UPDATE_3(DCSURF_ADDR_CONFIG,
319+
NUM_PIPES, log_2(info->gfx9.num_pipes),
320+
PIPE_INTERLEAVE, info->gfx9.pipe_interleave,
321+
MAX_COMPRESSED_FRAGS, log_2(info->gfx9.max_compressed_frags));
322+
323+
REG_UPDATE_4(DCSURF_TILING_CONFIG,
324+
SW_MODE, info->gfx9.swizzle,
325+
META_LINEAR, 0,
326+
RB_ALIGNED, 0,
327+
PIPE_ALIGNED, 0);
332328
}
333329

334330
void hubp2_program_size(

drivers/gpu/drm/amd/display/dc/hubp/dcn30/dcn30_hubp.c

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -321,22 +321,18 @@ void hubp3_program_tiling(
321321
const struct dc_tiling_info *info,
322322
const enum surface_pixel_format pixel_format)
323323
{
324-
ASSERT(info->gfxversion == DcGfxVersion9 || info->gfxversion == DcGfxBase);
325-
326-
if (info->gfxversion == DcGfxVersion9) {
327-
REG_UPDATE_4(DCSURF_ADDR_CONFIG,
328-
NUM_PIPES, log_2(info->gfx9.num_pipes),
329-
PIPE_INTERLEAVE, info->gfx9.pipe_interleave,
330-
MAX_COMPRESSED_FRAGS, log_2(info->gfx9.max_compressed_frags),
331-
NUM_PKRS, log_2(info->gfx9.num_pkrs));
332-
333-
REG_UPDATE_3(DCSURF_TILING_CONFIG,
334-
SW_MODE, info->gfx9.swizzle,
335-
META_LINEAR, info->gfx9.meta_linear,
336-
PIPE_ALIGNED, info->gfx9.pipe_aligned);
337-
} else {
338-
hubp3_clear_tiling(&hubp2->base);
339-
}
324+
ASSERT(info->gfxversion == DcGfxVersion9);
325+
326+
REG_UPDATE_4(DCSURF_ADDR_CONFIG,
327+
NUM_PIPES, log_2(info->gfx9.num_pipes),
328+
PIPE_INTERLEAVE, info->gfx9.pipe_interleave,
329+
MAX_COMPRESSED_FRAGS, log_2(info->gfx9.max_compressed_frags),
330+
NUM_PKRS, log_2(info->gfx9.num_pkrs));
331+
332+
REG_UPDATE_3(DCSURF_TILING_CONFIG,
333+
SW_MODE, info->gfx9.swizzle,
334+
META_LINEAR, info->gfx9.meta_linear,
335+
PIPE_ALIGNED, info->gfx9.pipe_aligned);
340336

341337
}
342338

0 commit comments

Comments
 (0)