Skip to content

Commit c277991

Browse files
chaseyuJaegeuk Kim
authored andcommitted
f2fs: remove unneeded in-memory i_crtime copy
i_crtime will never change after inode creation, so we don't need to copy it into f2fs_inode_info.i_disk_time[3], and monitor its change to decide whether updating inode page, remove related stuff. Signed-off-by: Chao Yu <chao@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
1 parent 68f0453 commit c277991

2 files changed

Lines changed: 1 addition & 5 deletions

File tree

fs/f2fs/f2fs.h

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -843,7 +843,7 @@ struct f2fs_inode_info {
843843
kprojid_t i_projid; /* id for project quota */
844844
int i_inline_xattr_size; /* inline xattr size */
845845
struct timespec64 i_crtime; /* inode creation time */
846-
struct timespec64 i_disk_time[4];/* inode disk times */
846+
struct timespec64 i_disk_time[3];/* inode disk times */
847847

848848
/* for file compress */
849849
atomic_t i_compr_blocks; /* # of compressed blocks */
@@ -3292,9 +3292,6 @@ static inline bool f2fs_is_time_consistent(struct inode *inode)
32923292
return false;
32933293
if (!timespec64_equal(F2FS_I(inode)->i_disk_time + 2, &inode->i_mtime))
32943294
return false;
3295-
if (!timespec64_equal(F2FS_I(inode)->i_disk_time + 3,
3296-
&F2FS_I(inode)->i_crtime))
3297-
return false;
32983295
return true;
32993296
}
33003297

fs/f2fs/inode.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,6 @@ static void init_idisk_time(struct inode *inode)
326326
fi->i_disk_time[0] = inode->i_atime;
327327
fi->i_disk_time[1] = inode->i_ctime;
328328
fi->i_disk_time[2] = inode->i_mtime;
329-
fi->i_disk_time[3] = fi->i_crtime;
330329
}
331330

332331
static int do_read_inode(struct inode *inode)

0 commit comments

Comments
 (0)