Skip to content

Commit c2d2280

Browse files
ZhangShuronghdeller
authored andcommitted
fbdev: fix potential OOB read in fast_imageblit()
There is a potential OOB read at fast_imageblit, for "colortab[(*src >> 4)]" can become a negative value due to "const char *s = image->data, *src". This change makes sure the index for colortab always positive or zero. Similar commit: https://patchwork.kernel.org/patch/11746067 Potential bug report: https://groups.google.com/g/syzkaller-bugs/c/9ubBXKeKXf4/m/k-QXy4UgAAAJ Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com> Cc: stable@vger.kernel.org Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 29c171d commit c2d2280

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/video/fbdev/core/sysimgblt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ static void fast_imageblit(const struct fb_image *image, struct fb_info *p,
189189
u32 fgx = fgcolor, bgx = bgcolor, bpp = p->var.bits_per_pixel;
190190
u32 ppw = 32/bpp, spitch = (image->width + 7)/8;
191191
u32 bit_mask, eorx, shift;
192-
const char *s = image->data, *src;
192+
const u8 *s = image->data, *src;
193193
u32 *dst;
194194
const u32 *tab;
195195
size_t tablen;

0 commit comments

Comments
 (0)