Skip to content

Commit c3076d1

Browse files
committed
backing-file: use credential guards for splice read
Use credential guards for scoped credential override with automatic restoration on scope exit. Link: https://patch.msgid.link/20251103-work-creds-guards-simple-v1-5-a3e156839e7f@kernel.org Reviewed-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent f119fea commit c3076d1

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

fs/backing-file.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -283,15 +283,13 @@ ssize_t backing_file_splice_read(struct file *in, struct kiocb *iocb,
283283
unsigned int flags,
284284
struct backing_file_ctx *ctx)
285285
{
286-
const struct cred *old_cred;
287286
ssize_t ret;
288287

289288
if (WARN_ON_ONCE(!(in->f_mode & FMODE_BACKING)))
290289
return -EIO;
291290

292-
old_cred = override_creds(ctx->cred);
293-
ret = vfs_splice_read(in, &iocb->ki_pos, pipe, len, flags);
294-
revert_creds(old_cred);
291+
scoped_with_creds(ctx->cred)
292+
ret = vfs_splice_read(in, &iocb->ki_pos, pipe, len, flags);
295293

296294
if (ctx->accessed)
297295
ctx->accessed(iocb->ki_filp);

0 commit comments

Comments
 (0)