Skip to content

Commit c42d12e

Browse files
jhovoldandersson
authored andcommitted
arm64: dts: qcom: sdm670: fix USB DP/DM HS PHY interrupts
The USB DP/DM HS PHY interrupts need to be provided by the PDC interrupt controller in order to be able to wake the system up from low-power states and to be able to detect disconnect events, which requires triggering on falling edges. A recent commit updated the trigger type but failed to change the interrupt provider as required. This leads to the current Linux driver failing to probe instead of printing an error during suspend and USB wakeup not working as intended. Fixes: de3b3de ("arm64: dts: qcom: sdm670: fix USB wakeup interrupt types") Fixes: 07c8ded ("arm64: dts: qcom: add sdm670 and pixel 3a device trees") Cc: stable@vger.kernel.org # 6.2 Cc: Richard Acayan <mailingradian@gmail.com> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Tested-by: Richard Acayan <mailingradian@gmail.com> Link: https://lore.kernel.org/r/20231214074319.11023-2-johan+linaro@kernel.org Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent b7b9a6a commit c42d12e

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

arch/arm64/boot/dts/qcom/sdm670.dtsi

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1320,10 +1320,10 @@
13201320
<&gcc GCC_USB30_PRIM_MASTER_CLK>;
13211321
assigned-clock-rates = <19200000>, <150000000>;
13221322

1323-
interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>,
1324-
<GIC_SPI 486 IRQ_TYPE_LEVEL_HIGH>,
1325-
<GIC_SPI 488 IRQ_TYPE_EDGE_BOTH>,
1326-
<GIC_SPI 489 IRQ_TYPE_EDGE_BOTH>;
1323+
interrupts-extended = <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>,
1324+
<&intc GIC_SPI 486 IRQ_TYPE_LEVEL_HIGH>,
1325+
<&pdc 8 IRQ_TYPE_EDGE_BOTH>,
1326+
<&pdc 9 IRQ_TYPE_EDGE_BOTH>;
13271327
interrupt-names = "hs_phy_irq", "ss_phy_irq",
13281328
"dm_hs_phy_irq", "dp_hs_phy_irq";
13291329

0 commit comments

Comments
 (0)