ARM: exynos: Fix refcount leak in exynos_map_pmu

Yuuoniy · krzk · commit c4c79525042a · 2022-06-06T10:40:57.000+02:00
of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. of_node_put() checks null pointer. Fixes: fce9e5b ("ARM: EXYNOS: Add support for mapping PMU base address via DT") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Link: https://lore.kernel.org/r/20220523145513.12341-1-linmq006@gmail.com Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
@@ -149,6 +149,7 @@ static void exynos_map_pmu(void)
 	np = of_find_matching_node(NULL, exynos_dt_pmu_match);
 	if (np)
 		pmu_base_addr = of_iomap(np, 0);
+	of_node_put(np);
 }
 
 static void __init exynos_init_irq(void)

Original file line number	Diff line number	Diff line change
`@@ -149,6 +149,7 @@ static void exynos_map_pmu(void)`
`149`	`149`	`np = of_find_matching_node(NULL, exynos_dt_pmu_match);`
`150`	`150`	`if (np)`
`151`	`151`	`pmu_base_addr = of_iomap(np, 0);`
	`152`	`+ of_node_put(np);`
`152`	`153`	`}`
`153`	`154`
`154`	`155`	`static void __init exynos_init_irq(void)`